linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Drivers:input:mousedev.c: Fixed trailing statement on the next line
@ 2014-11-29 15:39 Athira S
  2014-11-29 16:02 ` Belisko Marek
  0 siblings, 1 reply; 4+ messages in thread
From: Athira S @ 2014-11-29 15:39 UTC (permalink / raw)
  To: dmitry.torokhov; +Cc: linux-input, linux-kernel, Athira S

Fixed checkpatch error:
trailing statements should be on next line

Signed-off-by: Athira S <athirasnamby@gmail.com>
---
 drivers/input/mousedev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/input/mousedev.c b/drivers/input/mousedev.c
index b604564..be2cc5c 100644
--- a/drivers/input/mousedev.c
+++ b/drivers/input/mousedev.c
@@ -248,7 +248,8 @@ static void mousedev_key_event(struct mousedev *mousedev,
 	case BTN_4:
 	case BTN_EXTRA:		index = 4; break;
 
-	default:		return;
+	default:
+	return;
 	}
 
 	if (value) {
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] Drivers:input:mousedev.c: Fixed trailing statement on the next line
  2014-11-29 15:39 Athira S
@ 2014-11-29 16:02 ` Belisko Marek
  0 siblings, 0 replies; 4+ messages in thread
From: Belisko Marek @ 2014-11-29 16:02 UTC (permalink / raw)
  To: Athira S; +Cc: Dmitry Torokhov, linux-input, LKML

On Sat, Nov 29, 2014 at 4:39 PM, Athira S <athirasnamby@gmail.com> wrote:
> Fixed checkpatch error:
> trailing statements should be on next line
>
> Signed-off-by: Athira S <athirasnamby@gmail.com>
> ---
>  drivers/input/mousedev.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/input/mousedev.c b/drivers/input/mousedev.c
> index b604564..be2cc5c 100644
> --- a/drivers/input/mousedev.c
> +++ b/drivers/input/mousedev.c
> @@ -248,7 +248,8 @@ static void mousedev_key_event(struct mousedev *mousedev,
>         case BTN_4:
>         case BTN_EXTRA:         index = 4; break;
>
> -       default:                return;
> +       default:
> +       return;
           ^^^^ missing tab here
>         }
>
>         if (value) {
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

BR,

marek

-- 
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] Drivers:input:mousedev.c: Fixed trailing statement on the next line
@ 2014-11-29 16:20 Athira S
  2014-11-29 17:54 ` Joe Perches
  0 siblings, 1 reply; 4+ messages in thread
From: Athira S @ 2014-11-29 16:20 UTC (permalink / raw)
  To: dmitry.torokhov; +Cc: linux-input, linux-kernel, Athira S

Fixed checkpatch error:
trailing statements should be on next line

signed-off-by: Athira S <athirasnamby@gmail.com>
---
 drivers/input/mousedev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/input/mousedev.c b/drivers/input/mousedev.c
index be2cc5c..28988f5 100644
--- a/drivers/input/mousedev.c
+++ b/drivers/input/mousedev.c
@@ -248,8 +248,8 @@ static void mousedev_key_event(struct mousedev *mousedev,
 	case BTN_4:
 	case BTN_EXTRA:		index = 4; break;
 
-	default:
-	return;
+	default:	
+				return;
 	}
 
 	if (value) {
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] Drivers:input:mousedev.c: Fixed trailing statement on the next line
  2014-11-29 16:20 [PATCH] Drivers:input:mousedev.c: Fixed trailing statement on the next line Athira S
@ 2014-11-29 17:54 ` Joe Perches
  0 siblings, 0 replies; 4+ messages in thread
From: Joe Perches @ 2014-11-29 17:54 UTC (permalink / raw)
  To: Athira S; +Cc: dmitry.torokhov, linux-input, linux-kernel

On Sat, 2014-11-29 at 21:50 +0530, Athira S wrote:
> Fixed checkpatch error:
> trailing statements should be on next line
> 
> signed-off-by: Athira S <athirasnamby@gmail.com>
> ---
>  drivers/input/mousedev.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/input/mousedev.c b/drivers/input/mousedev.c
> index be2cc5c..28988f5 100644
> --- a/drivers/input/mousedev.c
> +++ b/drivers/input/mousedev.c
> @@ -248,8 +248,8 @@ static void mousedev_key_event(struct mousedev *mousedev,
>  	case BTN_4:
>  	case BTN_EXTRA:		index = 4; break;
>  
> -	default:
> -	return;
> +	default:	
> +				return;

Please run your suggested patches though
scripts/checkpatch.pl before sending them.

Don't send patches on top of your own
unapplied patches.  Use the original and
create a new patch.

Probably none of this needs to be changed.



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-11-29 17:54 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-29 16:20 [PATCH] Drivers:input:mousedev.c: Fixed trailing statement on the next line Athira S
2014-11-29 17:54 ` Joe Perches
  -- strict thread matches above, loose matches on Subject: below --
2014-11-29 15:39 Athira S
2014-11-29 16:02 ` Belisko Marek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).