From: Joe Perches <joe@perches.com>
To: Athira S <athirasnamby@gmail.com>
Cc: dmitry.torokhov@gmail.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Drivers:input:mousedev.c: Fixed trailing statement on the next line
Date: Sat, 29 Nov 2014 09:54:41 -0800 [thread overview]
Message-ID: <1417283681.818.1.camel@perches.com> (raw)
In-Reply-To: <1417278043-4870-1-git-send-email-athirasnamby@gmail.com>
On Sat, 2014-11-29 at 21:50 +0530, Athira S wrote:
> Fixed checkpatch error:
> trailing statements should be on next line
>
> signed-off-by: Athira S <athirasnamby@gmail.com>
> ---
> drivers/input/mousedev.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/mousedev.c b/drivers/input/mousedev.c
> index be2cc5c..28988f5 100644
> --- a/drivers/input/mousedev.c
> +++ b/drivers/input/mousedev.c
> @@ -248,8 +248,8 @@ static void mousedev_key_event(struct mousedev *mousedev,
> case BTN_4:
> case BTN_EXTRA: index = 4; break;
>
> - default:
> - return;
> + default:
> + return;
Please run your suggested patches though
scripts/checkpatch.pl before sending them.
Don't send patches on top of your own
unapplied patches. Use the original and
create a new patch.
Probably none of this needs to be changed.
next prev parent reply other threads:[~2014-11-29 17:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-29 16:20 [PATCH] Drivers:input:mousedev.c: Fixed trailing statement on the next line Athira S
2014-11-29 17:54 ` Joe Perches [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-11-29 15:39 Athira S
2014-11-29 16:02 ` Belisko Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1417283681.818.1.camel@perches.com \
--to=joe@perches.com \
--cc=athirasnamby@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).