linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dudley Du <dudley.dulixin@gmail.com>
To: dmitry.torokhov@gmail.com, rydberg@euromail.se
Cc: Dudley Du <dudley.dulixin@gmail.com>,
	bleung@google.com, linux-input@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v12 15/19] input: cyapa: add gen3 trackpad device read firmware image function support
Date: Wed,  3 Dec 2014 17:30:21 +0800	[thread overview]
Message-ID: <1417599025-21681-16-git-send-email-dudley.dulixin@gmail.com> (raw)
In-Reply-To: <1417599025-21681-1-git-send-email-dudley.dulixin@gmail.com>

Add read firmware image function supported for gen3 trackpad device,
it can be used through debugfs read_fw interface.
TEST=test on Chromebooks.

Signed-off-by: Dudley Du <dudley.dulixin@gmail.com>
---
 drivers/input/mouse/cyapa_gen3.c | 67 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 67 insertions(+)

diff --git a/drivers/input/mouse/cyapa_gen3.c b/drivers/input/mouse/cyapa_gen3.c
index 640b916..dd1313e 100644
--- a/drivers/input/mouse/cyapa_gen3.c
+++ b/drivers/input/mouse/cyapa_gen3.c
@@ -708,6 +708,36 @@ static int cyapa_gen3_write_fw_block(struct cyapa *cyapa,
 	return ret;
 }
 
+/*
+ * A firmware block read command reads 16 bytes of data from flash starting
+ * from a given address.  The 12-byte block read command has the format:
+ *   <0xff> <CMD> <Key> <Addr>
+ *
+ *  <0xff>  - every command starts with 0xff
+ *  <CMD>   - the read command value is 0x3c
+ *  <Key>   - read commands include an 8-byte key: { 00 01 02 03 04 05 06 07 }
+ *  <Addr>  - Memory address (16-bit, big-endian)
+ *
+ * The command is followed by an i2c block read to read the 16 bytes of data.
+ */
+static int cyapa_gen3_read_fw_bytes(struct cyapa *cyapa, u16 addr, u8 *data)
+{
+	u8 cmd[] = { 0xff, 0x3c, 0x00, 0x01, 0x02, 0x03, 0x04,
+		0x05, 0x06, 0x07, addr >> 8, addr };
+	int ret, error;
+
+	error = cyapa_gen3_write_buffer(cyapa, cmd, sizeof(cmd));
+	if (error)
+		return error;
+
+	/* Read data buffer starting from offset 16 */
+	ret = cyapa_i2c_reg_read_block(cyapa, 16, CYAPA_FW_READ_SIZE, data);
+	if (ret != CYAPA_FW_READ_SIZE)
+		return (ret < 0) ? ret : -EIO;
+
+	return 0;
+}
+
 static int cyapa_gen3_write_blocks(struct cyapa *cyapa,
 		size_t start_block, size_t block_count,
 		const u8 *image_data)
@@ -754,6 +784,41 @@ static int cyapa_gen3_do_fw_update(struct cyapa *cyapa,
 	return 0;
 }
 
+/*
+ * Read the entire firmware image into ->fw_image.
+ * If the ->fw_image has already been allocated, then this function
+ * doesn't do anything and just returns 0.
+ * If an error occurs while reading the image, ->fw_image is freed, and
+ * the error is returned.
+ *
+ * The firmware is a fixed size (CYAPA_FW_SIZE), and is read out in
+ * fixed length (CYAPA_FW_READ_SIZE) chunks.
+ */
+static int cyapa_gen3_read_fw(struct cyapa *cyapa)
+{
+	int error;
+	int addr;
+
+	error = cyapa_gen3_bl_enter(cyapa);
+	if (error)
+		return error;
+
+	cyapa->fw_image = cyapa->fw_image ? cyapa->fw_image :
+		devm_kzalloc(&cyapa->client->dev, CYAPA_FW_SIZE, GFP_KERNEL);
+	if (!cyapa->fw_image)
+		return -ENOMEM;
+
+	for (addr = 0; addr < CYAPA_FW_SIZE; addr += CYAPA_FW_READ_SIZE) {
+		error = cyapa_gen3_read_fw_bytes(cyapa,
+			CYAPA_FW_HDR_START + addr, &cyapa->fw_image[addr]);
+		if (error)
+			return error;
+	}
+
+	cyapa->fw_image_size = CYAPA_FW_SIZE;
+	return 0;
+}
+
 static ssize_t cyapa_gen3_do_calibrate(struct device *dev,
 				     struct device_attribute *attr,
 				     const char *buf, size_t count)
@@ -1195,6 +1260,8 @@ const struct cyapa_dev_ops cyapa_gen3_ops = {
 	.show_baseline = cyapa_gen3_show_baseline,
 	.calibrate_store = cyapa_gen3_do_calibrate,
 
+	.read_fw = cyapa_gen3_read_fw,
+
 	.state_parse = cyapa_gen3_state_parse,
 	.operational_check = cyapa_gen3_do_operational_check,
 
-- 
1.9.1

  parent reply	other threads:[~2014-12-03  9:30 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-03  9:30 [PATCH v12 00/19] input: cyapa: instruction of cyapa patches Dudley Du
2014-12-03  9:30 ` [PATCH v12 01/19] input: cyapa: modify code to following kernel code style Dudley Du
2014-12-03  9:30 ` [PATCH v12 02/19] input: cyapa: add device resource management infrastructure support Dudley Du
2014-12-04 17:43   ` Dmitry Torokhov
2014-12-03  9:30 ` [PATCH v12 03/19] input: cyapa: re-design driver to support multi-trackpad in one driver Dudley Du
2014-12-03  9:30 ` [PATCH v12 04/19] input: cyapa: add gen5 trackpad device basic functions support Dudley Du
2014-12-03  9:30 ` [PATCH v12 05/19] input: cyapa: add power management interfaces supported for the device Dudley Du
2014-12-03  9:30 ` [PATCH v12 06/19] input: cyapa: add runtime " Dudley Du
2014-12-03  9:30 ` [PATCH v12 07/19] input: cyapa: add sysfs interfaces supported in the cyapa driver Dudley Du
2014-12-03  9:30 ` [PATCH v12 08/19] input: cyapa: add gen3 trackpad device firmware update function support Dudley Du
2014-12-03  9:30 ` [PATCH v12 09/19] input: cyapa: add gen3 trackpad device read baseline " Dudley Du
2014-12-03  9:30 ` [PATCH v12 10/19] input: cyapa: add gen3 trackpad device force re-calibrate " Dudley Du
2014-12-03  9:30 ` [PATCH v12 11/19] input: cyapa: add gen5 trackpad device firmware update " Dudley Du
2014-12-03  9:30 ` [PATCH v12 12/19] input: cyapa: add gen5 trackpad device read baseline " Dudley Du
2014-12-03  9:30 ` [PATCH v12 13/19] input: cyapa: add gen5 trackpad device force re-calibrate " Dudley Du
2014-12-03  9:30 ` [PATCH v12 14/19] input: cyapa: add read firmware image debugfs interface support Dudley Du
2014-12-03  9:30 ` Dudley Du [this message]
2014-12-03  9:30 ` [PATCH v12 16/19] input: cyapa: add gen5 trackpad device read firmware image function support Dudley Du
2014-12-03  9:30 ` [PATCH v12 17/19] input: cyapa: add read sensors raw data debugfs interface support Dudley Du
2014-12-03  9:30 ` [PATCH v12 18/19] input: cyapa: add gen5 trackpad device read raw data function support Dudley Du
2014-12-03  9:30 ` [PATCH v12 19/19] input: cyapa: add acpi device id supported Dudley Du

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1417599025-21681-16-git-send-email-dudley.dulixin@gmail.com \
    --to=dudley.dulixin@gmail.com \
    --cc=bleung@google.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rydberg@euromail.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).