From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org,
Alexander Stein <alexander.stein@systec-electronic.com>,
Linus Walleij <linus.walleij@linaro.org>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
Alexander Shiyan <shc_work@mail.ru>,
Laxman Dewangan <ldewangan@nvidia.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Input: gpio_keys - replace timer and workqueue with delayed workqueue
Date: Mon, 15 Dec 2014 12:20:49 +0200 [thread overview]
Message-ID: <1418638849.17201.65.camel@linux.intel.com> (raw)
In-Reply-To: <20141213190926.GD22702@dtor-ws>
On Sat, 2014-12-13 at 11:09 -0800, Dmitry Torokhov wrote:
> Hi Andy,
>
> On Wed, Dec 10, 2014 at 08:32:56PM +0200, Andy Shevchenko wrote:
> > On Sun, 2014-12-07 at 23:21 -0800, Dmitry Torokhov wrote:
> > > We do not need to roll our own implementation of delayed work now that we
> > > have proper implementation of mod_delayed_work.
> > >
> > > For interrupt-only driven buttons we retain the timer, but we rename
> > > it to release_timer to better reflect its purpose.
> >
> > At least it doesn't break the driver on Intel Medfield device.
> >
> > Tested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Thank you for testing it. Assume it is for both patches, right?
Right.
--
Andy Shevchenko <andriy.shevchenko@intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2014-12-15 10:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-08 7:19 [PATCH 1/2] Input: gpio_keys - allow separating gpio and irq in device tree Dmitry Torokhov
2014-12-08 7:21 ` [PATCH 2/2] Input: gpio_keys - replace timer and workqueue with delayed workqueue Dmitry Torokhov
2014-12-10 18:32 ` Andy Shevchenko
2014-12-13 19:09 ` Dmitry Torokhov
2014-12-15 10:20 ` Andy Shevchenko [this message]
2014-12-14 9:05 ` Linus Walleij
2014-12-31 8:22 ` [PATCH 1/2] Input: gpio_keys - allow separating gpio and irq in device tree Linus Walleij
2015-01-04 22:27 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418638849.17201.65.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alexander.stein@systec-electronic.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=ezequiel.garcia@free-electrons.com \
--cc=ldewangan@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shc_work@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).