From: Vignesh R <vigneshr@ti.com>
To: Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Mark Rutland <mark.rutland@arm.com>, Vignesh R <vigneshr@ti.com>,
Wolfram Sang <wsa@the-dreams.de>,
linux-iio@vger.kernel.org,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Peter Meerwald <pmeerw@pmeerw.net>,
Lars-Peter Clausen <lars@metafoo.de>,
Russell King <linux@arm.linux.org.uk>,
Jan Kardell <jan.kardell@telliq.com>,
Tony Lindgren <tony@atomide.com>,
linux-input@vger.kernel.org,
Sanjeev Sharma <sanjeev_sharma@mentor.com>,
devicetree@vger.kernel.org, Brad Griffis <bgriffis@ti.com>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Rob Herring <robh+dt@kernel.org>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Samuel Ortiz <sameo@linux.intel.com>,
linux-kernel@vger.kernel.org, Felipe Balbi <balbi@ti.com>,
Benoit Cousson <bcousson@baylibre.com>,
Kumar Gala <galak@codeaurora.org>
Subject: [PATCH v5 5/6] input: touchscreen: ti_am335x_tsc: Use charge delay DT parameter
Date: Wed, 24 Dec 2014 12:33:38 +0530 [thread overview]
Message-ID: <1419404619-10744-6-git-send-email-vigneshr@ti.com> (raw)
In-Reply-To: <1419404619-10744-1-git-send-email-vigneshr@ti.com>
This patch reads charge delay from tsc DT node and writes to
REG_CHARGEDELAY register. If the charge delay is not specified in DT
then default value of 0x400(CHARGEDLY_OPENDLY) is used.
Signed-off-by: Vignesh R <vigneshr@ti.com>
---
v5:
- print out a warning when ti,charge-delay is not specified
drivers/input/touchscreen/ti_am335x_tsc.c | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/touchscreen/ti_am335x_tsc.c
index 8650b1dd24dc..9cb8b4a01dca 100644
--- a/drivers/input/touchscreen/ti_am335x_tsc.c
+++ b/drivers/input/touchscreen/ti_am335x_tsc.c
@@ -52,6 +52,7 @@ struct titsc {
u32 bit_xp, bit_xn, bit_yp, bit_yn;
u32 inp_xp, inp_xn, inp_yp, inp_yn;
u32 step_mask;
+ u32 charge_delay;
};
static unsigned int titsc_readl(struct titsc *ts, unsigned int reg)
@@ -177,7 +178,7 @@ static void titsc_step_config(struct titsc *ts_dev)
config = titsc_readl(ts_dev, REG_IDLECONFIG);
titsc_writel(ts_dev, REG_CHARGECONFIG, config);
- titsc_writel(ts_dev, REG_CHARGEDELAY, CHARGEDLY_OPENDLY);
+ titsc_writel(ts_dev, REG_CHARGEDELAY, ts_dev->charge_delay);
/* coordinate_readouts + 1 ... coordinate_readouts + 2 is for Z */
config = STEPCONFIG_MODE_HWSYNC |
@@ -368,6 +369,17 @@ static int titsc_parse_dt(struct platform_device *pdev,
if (err < 0)
return err;
+ err = of_property_read_u32(node, "ti,charge-delay",
+ &ts_dev->charge_delay);
+ /*
+ * If ti,charge-delay value is not specified, then use CHARGEDLY_OPENDLY
+ * as the default value.
+ */
+ if (err < 0) {
+ ts_dev->charge_delay = CHARGEDLY_OPENDLY;
+ dev_warn(&pdev->dev, "ti,charge-delay not specified\n");
+ }
+
return of_property_read_u32_array(node, "ti,wire-config",
ts_dev->config_inp, ARRAY_SIZE(ts_dev->config_inp));
}
--
1.9.1
next prev parent reply other threads:[~2014-12-24 7:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-24 7:03 [PATCH v5 0/6] Touchscreen performance related fixes Vignesh R
2014-12-24 7:03 ` [PATCH v5 1/6] input: touchscreen: ti_am335x_tsc Interchange touchscreen and ADC steps Vignesh R
[not found] ` <1419404619-10744-1-git-send-email-vigneshr-l0cyMroinI0@public.gmane.org>
2014-12-24 7:03 ` [PATCH v5 2/6] input: touchscreen: ti_am335x_tsc: Remove udelay in interrupt handler Vignesh R
2014-12-24 7:03 ` [PATCH v5 3/6] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save Vignesh R
2014-12-24 7:03 ` [PATCH v5 4/6] ARM: dts: AM335x: Make charge delay a DT parameter for TSC Vignesh R
[not found] ` <1419404619-10744-5-git-send-email-vigneshr-l0cyMroinI0@public.gmane.org>
2015-01-02 17:09 ` Tony Lindgren
[not found] ` <20150102170933.GB3298-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2015-01-07 5:47 ` Vignesh R
2014-12-24 7:03 ` Vignesh R [this message]
2014-12-24 7:03 ` [PATCH v5 6/6] input: touchscreen: ti_am335x_tsc: Replace delta filtering with median filtering Vignesh R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1419404619-10744-6-git-send-email-vigneshr@ti.com \
--to=vigneshr@ti.com \
--cc=balbi@ti.com \
--cc=bcousson@baylibre.com \
--cc=bgriffis@ti.com \
--cc=bigeasy@linutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jan.kardell@telliq.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=paul.gortmaker@windriver.com \
--cc=pawel.moll@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=sameo@linux.intel.com \
--cc=sanjeev_sharma@mentor.com \
--cc=tony@atomide.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).