linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Gabriele Mazzotta <gabriele.mzt@gmail.com>
To: dmitry.torokhov@gmail.com, rydberg@euromail.se
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	silverhammermba@gmail.com,
	Gabriele Mazzotta <gabriele.mzt@gmail.com>
Subject: [PATCH 2/2] input: synaptics - fix width calculation on image sensors
Date: Sat, 27 Dec 2014 12:31:29 +0100	[thread overview]
Message-ID: <1419679889-6582-3-git-send-email-gabriele.mzt@gmail.com> (raw)
In-Reply-To: <1419679889-6582-1-git-send-email-gabriele.mzt@gmail.com>

When two or more fingers are on the touchpad, the 'w' slot holds the
finger count rather than the width. Retrieve the correct value encoded
in the lower bits of 'x', 'y' and 'z'.

The minimum width reported is 8 rather than 4 in this case, while the
maximum remains 15.

Signed-off-by: Gabriele Mazzotta <gabriele.mzt@gmail.com>
---
 drivers/input/mouse/synaptics.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index ea0563e..5ff4c5b 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -593,7 +593,9 @@ static void synaptics_parse_agm(const unsigned char buf[],
 	switch (agm_packet_type) {
 	case 1:
 		/* Gesture packet: (x, y, z) half resolution */
-		agm->w = hw->w;
+		agm->w = ((buf[1] & 0x01) |
+			  ((buf[2] & 0x01) << 1) |
+			  ((buf[5] & 0x01) << 2)) + 8;
 		agm->x = (((buf[4] & 0x0f) << 8) | buf[1]) << 1;
 		agm->y = (((buf[4] & 0xf0) << 4) | buf[2]) << 1;
 		agm->z = ((buf[3] & 0x30) | (buf[5] & 0x0f)) << 1;
-- 
2.1.4

  parent reply	other threads:[~2014-12-27 11:31 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-27 11:31 [PATCH 0/2] input: synaptics - make image sensors report finger widths Gabriele Mazzotta
2014-12-27 11:31 ` [PATCH 1/2] input: synaptics - make image sensors report ABS_MT_TOUCH_MAJOR Gabriele Mazzotta
2015-01-05 19:24   ` Benjamin Tissoires
2015-01-05 20:13     ` Gabriele Mazzotta
2015-01-05 20:18       ` Gabriele Mazzotta
2015-01-05 22:00     ` Gabriele Mazzotta
2015-01-05 22:04       ` Benjamin Tissoires
2015-01-07  6:10         ` Peter Hutterer
2015-01-07  7:49         ` Dmitry Torokhov
2015-01-07  6:02     ` Peter Hutterer
2014-12-27 11:31 ` Gabriele Mazzotta [this message]
2015-01-05 18:25   ` [PATCH 2/2] input: synaptics - fix width calculation on image sensors Benjamin Tissoires
2015-01-05 18:37     ` Gabriele Mazzotta
2015-01-05 18:42       ` Benjamin Tissoires
2015-01-05 19:04         ` Dmitry Torokhov
2015-01-05 19:07           ` Benjamin Tissoires
2015-01-05 19:15           ` Gabriele Mazzotta
2015-01-05 19:26             ` Benjamin Tissoires

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1419679889-6582-3-git-send-email-gabriele.mzt@gmail.com \
    --to=gabriele.mzt@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rydberg@euromail.se \
    --cc=silverhammermba@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).