From: Aniroop Mathur <aniroop.mathur@gmail.com>
To: dmitry.torokhov@gmail.com, dtor@mail.ru, linux-input@vger.kernel.org
Cc: aniroop.mathur@gmail.com, a.mathur@samsung.com
Subject: [PATCH] Input: Avoid kernel panic during device unregistration
Date: Sun, 28 Dec 2014 23:42:05 +0530 [thread overview]
Message-ID: <1419790325-4004-1-git-send-email-aniroop.mathur@gmail.com> (raw)
This patch adds null check before actually unregistering the input device
to avoid null pointer exception which leads to kernel panic.
So now, input device drivers won't have to worry about or add null case
condition before calling input_unregister_device() in shutdown and
remove functions.
Signed-off-by: Aniroop Mathur <a.mathur@samsung.com>
---
drivers/input/input.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/input/input.c b/drivers/input/input.c
index 01fe49e..575219d 100644
--- a/drivers/input/input.c
+++ b/drivers/input/input.c
@@ -2170,6 +2170,9 @@ EXPORT_SYMBOL(input_register_device);
*/
void input_unregister_device(struct input_dev *dev)
{
+ if (!dev)
+ return;
+
if (dev->devres_managed) {
WARN_ON(devres_destroy(dev->dev.parent,
devm_input_device_unregister,
--
1.9.1
next reply other threads:[~2014-12-28 18:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-28 18:12 Aniroop Mathur [this message]
2014-12-28 20:21 ` [PATCH] Input: Avoid kernel panic during device unregistration Dmitry Torokhov
2014-12-29 16:41 ` Aniroop Mathur
2014-12-29 17:23 ` Dmitry Torokhov
2014-12-29 17:38 ` Aniroop Mathur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1419790325-4004-1-git-send-email-aniroop.mathur@gmail.com \
--to=aniroop.mathur@gmail.com \
--cc=a.mathur@samsung.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dtor@mail.ru \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).