From: Gabriele Mazzotta <gabriele.mzt@gmail.com>
To: linux-input@vger.kernel.org
Cc: dmitry.torokhov@gmail.com, rydberg@euromail.se,
linux-kernel@vger.kernel.org, silverhammermba@gmail.com,
peter.hutterer@who-t.net, hdegoede@redhat.com,
benjamin.tissoires@gmail.com,
Gabriele Mazzotta <gabriele.mzt@gmail.com>
Subject: [PATCH v2 2/4] input: synaptics - fix width values calculation on image sensors
Date: Mon, 5 Jan 2015 23:28:33 +0100 [thread overview]
Message-ID: <1420496915-31560-3-git-send-email-gabriele.mzt@gmail.com> (raw)
In-Reply-To: <1420496915-31560-1-git-send-email-gabriele.mzt@gmail.com>
When multiple fingers are on the touchpad, W reports the finger
count rather than the width. Retrieve the correct value that is
encoded in X, Y and Z of AGM and SGM packets.
The minimum width reported is 8 rather than 4 in this case, while the
maximum remains 15.
Signed-off-by: Gabriele Mazzotta <gabriele.mzt@gmail.com>
---
drivers/input/mouse/synaptics.c | 21 +++++++++++++++++----
1 file changed, 17 insertions(+), 4 deletions(-)
diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index 4d22ebd..918a727 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -585,10 +585,12 @@ static void synaptics_parse_agm(const unsigned char buf[],
switch (agm_packet_type) {
case 1:
/* Gesture packet: (x, y, z) half resolution */
- agm->w = hw->w;
- agm->x = (((buf[4] & 0x0f) << 8) | buf[1]) << 1;
- agm->y = (((buf[4] & 0xf0) << 4) | buf[2]) << 1;
- agm->z = ((buf[3] & 0x30) | (buf[5] & 0x0f)) << 2;
+ agm->w = ((buf[1] & 0x01) |
+ ((buf[2] & 0x01) << 1) |
+ ((buf[5] & 0x01) << 2)) + 8;
+ agm->x = (((buf[4] & 0x0f) << 8) | (buf[1] & 0xfe)) << 1;
+ agm->y = (((buf[4] & 0xf0) << 4) | (buf[2] & 0xfe)) << 1;
+ agm->z = ((buf[3] & 0x30) | (buf[5] & 0x0e)) << 2;
break;
case 2:
@@ -852,6 +854,17 @@ static void synaptics_image_sensor_process(struct psmouse *psmouse,
else
num_fingers = 4;
+ /* When multiple fingers are on the TouchPad, the width is encoded in
+ * X, Y and Z */
+ if (sgm->w == 0 || sgm->w == 1) {
+ sgm->w = (((sgm->x & BIT(1)) >> 1) |
+ (sgm->y & BIT(1)) |
+ ((sgm->z & BIT(0)) << 2)) + 8;
+ sgm->x &= ~BIT(1);
+ sgm->y &= ~BIT(1);
+ sgm->z &= ~BIT(0);
+ }
+
/* Send resulting input events to user space */
synaptics_report_mt_data(psmouse, sgm, num_fingers);
}
--
2.1.4
next prev parent reply other threads:[~2015-01-05 22:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-05 22:28 [PATCH v2 0/4] input: synaptics - report correct width and pressure values Gabriele Mazzotta
2015-01-05 22:28 ` [PATCH v2 1/4] input: synaptics - fix pressure values calculation on image sensors Gabriele Mazzotta
2015-01-05 22:28 ` Gabriele Mazzotta [this message]
2015-01-05 22:28 ` [PATCH v2 3/4] input: synaptics - change default width value of cr48 sensors Gabriele Mazzotta
2015-01-05 22:28 ` [PATCH v2 4/4] input: synaptics - make semi-mt touchpads report widths Gabriele Mazzotta
2015-01-09 10:10 ` [PATCH v2 0/4] input: synaptics - report correct width and pressure values Oliver Neukum
2015-02-22 19:23 ` Gabriele Mazzotta
2015-03-09 21:35 ` Gabriele Mazzotta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1420496915-31560-3-git-send-email-gabriele.mzt@gmail.com \
--to=gabriele.mzt@gmail.com \
--cc=benjamin.tissoires@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.hutterer@who-t.net \
--cc=rydberg@euromail.se \
--cc=silverhammermba@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).