[PATCH 0/9] Asynchronous attribute reads

[PATCH 0/9] Asynchronous attribute reads

[Srinivas Pandruvada]

Patches related to asynchronous attribute reads. This series
enhances core and driver using this API.

Srinivas Pandruvada (9):
  HID: hid-sensor-hub: Extend API for async reads
  iio: hid-sensor-accel-3d: Adjust parameter for attribute read
  iio: hid-sensor-gyro-3d: Adjust parameter for attribute read
  iio: hid-sensor-als: Adjust parameter for attribute read
  iio: hid-sensor-prox: Adjust parameter for attribute read
  iio: hid-sensor-magn-3d: Adjust parameter for attribute read
  iio: hid-sensor-incl-3d: Adjust parameter for attribute read
  iio: hid-sensor-press: Adjust parameter for attribute read
  drivers/rtc/rtc-hid-sensor-time.c: Adjust parameter for attribute read

 drivers/hid/hid-sensor-hub.c                  | 15 ++++++++++++++-
 drivers/iio/accel/hid-sensor-accel-3d.c       |  3 ++-
 drivers/iio/gyro/hid-sensor-gyro-3d.c         |  3 ++-
 drivers/iio/light/hid-sensor-als.c            |  3 ++-
 drivers/iio/light/hid-sensor-prox.c           |  3 ++-
 drivers/iio/magnetometer/hid-sensor-magn-3d.c |  3 ++-
 drivers/iio/orientation/hid-sensor-incl-3d.c  |  3 ++-
 drivers/iio/pressure/hid-sensor-press.c       |  3 ++-
 drivers/rtc/rtc-hid-sensor-time.c             |  2 +-
 include/linux/hid-sensor-hub.h                | 19 +++++++++++++------
 10 files changed, 42 insertions(+), 15 deletions(-)

-- 
1.9.3

[PATCH 2/9] iio: hid-sensor-accel-3d: Adjust parameter for attribute read

[Srinivas Pandruvada]

The new API added a flag for sync/async mode. Added sync mode flag.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---
 drivers/iio/accel/hid-sensor-accel-3d.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/accel/hid-sensor-accel-3d.c b/drivers/iio/accel/hid-sensor-accel-3d.c
index d5d9531..0085c2f 100644
--- a/drivers/iio/accel/hid-sensor-accel-3d.c
+++ b/drivers/iio/accel/hid-sensor-accel-3d.c
@@ -130,7 +130,8 @@ static int accel_3d_read_raw(struct iio_dev *indio_dev,
 			*val = sensor_hub_input_attr_get_raw_value(
 					accel_state->common_attributes.hsdev,
 					HID_USAGE_SENSOR_ACCEL_3D, address,
-					report_id);
+					report_id,
+					SENSOR_HUB_SYNC);
 		else {
 			*val = 0;
 			hid_sensor_power_state(&accel_state->common_attributes,
-- 
1.9.3

Re: [PATCH 2/9] iio: hid-sensor-accel-3d: Adjust parameter for attribute read

[Jonathan Cameron]

On 07/01/15 18:47, Srinivas Pandruvada wrote:
> The new API added a flag for sync/async mode. Added sync mode flag.
> 
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Again, please don't break the build between patches like this.

If you want to do things in steps, you'll have to carry to versions of
the function during the conversion and drop the unwanted one at the end.

> ---
>  drivers/iio/accel/hid-sensor-accel-3d.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/accel/hid-sensor-accel-3d.c b/drivers/iio/accel/hid-sensor-accel-3d.c
> index d5d9531..0085c2f 100644
> --- a/drivers/iio/accel/hid-sensor-accel-3d.c
> +++ b/drivers/iio/accel/hid-sensor-accel-3d.c
> @@ -130,7 +130,8 @@ static int accel_3d_read_raw(struct iio_dev *indio_dev,
>  			*val = sensor_hub_input_attr_get_raw_value(
>  					accel_state->common_attributes.hsdev,
>  					HID_USAGE_SENSOR_ACCEL_3D, address,
> -					report_id);
> +					report_id,
> +					SENSOR_HUB_SYNC);
>  		else {
>  			*val = 0;
>  			hid_sensor_power_state(&accel_state->common_attributes,
> 

Re: [PATCH 2/9] iio: hid-sensor-accel-3d: Adjust parameter for attribute read

[Srinivas Pandruvada]

On 01/10/2015 02:42 PM, Jonathan Cameron wrote:
> On 07/01/15 18:47, Srinivas Pandruvada wrote:
>> The new API added a flag for sync/async mode. Added sync mode flag.
>>
>> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> Again, please don't break the build between patches like this.
As we did in the past, the hid sensor hub patches involving hid sensor 
and IIO part goes through one tree, either via IIO or HID.
So once acked this needs to go through a single tree, as done in the past.
So the patches submitted in a series to avoid breaking build.

Thanks,
Srinivas
>
> If you want to do things in steps, you'll have to carry to versions of
> the function during the conversion and drop the unwanted one at the end.
>
>> ---
>>   drivers/iio/accel/hid-sensor-accel-3d.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/iio/accel/hid-sensor-accel-3d.c b/drivers/iio/accel/hid-sensor-accel-3d.c
>> index d5d9531..0085c2f 100644
>> --- a/drivers/iio/accel/hid-sensor-accel-3d.c
>> +++ b/drivers/iio/accel/hid-sensor-accel-3d.c
>> @@ -130,7 +130,8 @@ static int accel_3d_read_raw(struct iio_dev *indio_dev,
>>   			*val = sensor_hub_input_attr_get_raw_value(
>>   					accel_state->common_attributes.hsdev,
>>   					HID_USAGE_SENSOR_ACCEL_3D, address,
>> -					report_id);
>> +					report_id,
>> +					SENSOR_HUB_SYNC);
>>   		else {
>>   			*val = 0;
>>   			hid_sensor_power_state(&accel_state->common_attributes,
>>
>

Re: [PATCH 2/9] iio: hid-sensor-accel-3d: Adjust parameter for attribute read

[Srinivas Pandruvada]

On 01/11/2015 03:08 PM, Srinivas Pandruvada wrote:
>
> On 01/10/2015 02:42 PM, Jonathan Cameron wrote:
>> On 07/01/15 18:47, Srinivas Pandruvada wrote:
>>> The new API added a flag for sync/async mode. Added sync mode flag.
>>>
>>> Signed-off-by: Srinivas Pandruvada 
>>> <srinivas.pandruvada@linux.intel.com>
>> Again, please don't break the build between patches like this.
> As we did in the past, the hid sensor hub patches involving hid sensor 
> and IIO part goes through one tree, either via IIO or HID.
> So once acked this needs to go through a single tree, as done in the 
> past.
> So the patches submitted in a series to avoid breaking build.
>
Ignore this comment.
Is this not a common procedure for API change? Single patch touching 
various subsystem, will be more difficult to apply.


> Thanks,
> Srinivas
>>
>> If you want to do things in steps, you'll have to carry to versions of
>> the function during the conversion and drop the unwanted one at the end.
>>
>>> ---
>>>   drivers/iio/accel/hid-sensor-accel-3d.c | 3 ++-
>>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/iio/accel/hid-sensor-accel-3d.c 
>>> b/drivers/iio/accel/hid-sensor-accel-3d.c
>>> index d5d9531..0085c2f 100644
>>> --- a/drivers/iio/accel/hid-sensor-accel-3d.c
>>> +++ b/drivers/iio/accel/hid-sensor-accel-3d.c
>>> @@ -130,7 +130,8 @@ static int accel_3d_read_raw(struct iio_dev 
>>> *indio_dev,
>>>               *val = sensor_hub_input_attr_get_raw_value(
>>>                       accel_state->common_attributes.hsdev,
>>>                       HID_USAGE_SENSOR_ACCEL_3D, address,
>>> -                    report_id);
>>> +                    report_id,
>>> +                    SENSOR_HUB_SYNC);
>>>           else {
>>>               *val = 0;
>>> hid_sensor_power_state(&accel_state->common_attributes,
>>>
>>
>

Re: [PATCH 2/9] iio: hid-sensor-accel-3d: Adjust parameter for attribute read

[Jonathan Cameron]

On 11/01/15 23:24, Srinivas Pandruvada wrote:
> 
> On 01/11/2015 03:08 PM, Srinivas Pandruvada wrote:
>>
>> On 01/10/2015 02:42 PM, Jonathan Cameron wrote:
>>> On 07/01/15 18:47, Srinivas Pandruvada wrote:
>>>> The new API added a flag for sync/async mode. Added sync mode flag.
>>>>
>>>> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
>>> Again, please don't break the build between patches like this.
>> As we did in the past, the hid sensor hub patches involving hid sensor and IIO part goes through one tree, either via IIO or HID.
>> So once acked this needs to go through a single tree, as done in the past.
>> So the patches submitted in a series to avoid breaking build.
>>
> Ignore this comment.
> Is this not a common procedure for API change? Single patch touching various subsystem, will be more difficult to apply.
Take one more step in doing it.
First you introduce a new function with the arguments changed
as you like.

Second you move all calls over to the new function.

Third you kill off the old function - sometimes you also do an easily
verified rename of all functions at once.

How the last patch gets applied is rather dependent on what it touches.
If just a couple of subsystems, then the maintainers tend to agree on who
is taking the series and if useful they create an immutable branch which
can then be pulled into any trees that need the change.  Doesn't matter
who ends up sending the pull request to Linus as Git will sort it all out.

If it's really kernel wide, then you need to get in touch with Linus.
Typically these are done at very specific points in the merge cycle - often
either just before or just after rc1 I think.

Rafael did one of these whilst changing some stuff with power management
kconfig dependencies in the last cycle.  It bit me because I was
running a couple of months behind mainline, but mostly it went in
without causing trouble.

Here, I'd probably just Ack the series and let Jiri pick it up and
keep a vague eye open for possible merge conflicts later in the cycle.


Jonathan
> 
> 
>> Thanks,
>> Srinivas
>>>
>>> If you want to do things in steps, you'll have to carry to versions of
>>> the function during the conversion and drop the unwanted one at the end.
>>>
>>>> ---
>>>>   drivers/iio/accel/hid-sensor-accel-3d.c | 3 ++-
>>>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/iio/accel/hid-sensor-accel-3d.c b/drivers/iio/accel/hid-sensor-accel-3d.c
>>>> index d5d9531..0085c2f 100644
>>>> --- a/drivers/iio/accel/hid-sensor-accel-3d.c
>>>> +++ b/drivers/iio/accel/hid-sensor-accel-3d.c
>>>> @@ -130,7 +130,8 @@ static int accel_3d_read_raw(struct iio_dev *indio_dev,
>>>>               *val = sensor_hub_input_attr_get_raw_value(
>>>>                       accel_state->common_attributes.hsdev,
>>>>                       HID_USAGE_SENSOR_ACCEL_3D, address,
>>>> -                    report_id);
>>>> +                    report_id,
>>>> +                    SENSOR_HUB_SYNC);
>>>>           else {
>>>>               *val = 0;
>>>> hid_sensor_power_state(&accel_state->common_attributes,
>>>>
>>>
>>
> 

Re: [PATCH 2/9] iio: hid-sensor-accel-3d: Adjust parameter for attribute read

[Srinivas Pandruvada]

On Mon, 2015-01-12 at 21:24 +0000, Jonathan Cameron wrote: 
> On 11/01/15 23:24, Srinivas Pandruvada wrote:
> > 
> > On 01/11/2015 03:08 PM, Srinivas Pandruvada wrote:
> >>
> >> On 01/10/2015 02:42 PM, Jonathan Cameron wrote:
> >>> On 07/01/15 18:47, Srinivas Pandruvada wrote:
> >>>> The new API added a flag for sync/async mode. Added sync mode flag.
> >>>>
> >>>> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> >>> Again, please don't break the build between patches like this.
> >> As we did in the past, the hid sensor hub patches involving hid sensor and IIO part goes through one tree, either via IIO or HID.
> >> So once acked this needs to go through a single tree, as done in the past.
> >> So the patches submitted in a series to avoid breaking build.
> >>
> > Ignore this comment.
> > Is this not a common procedure for API change? Single patch touching various subsystem, will be more difficult to apply.
> Take one more step in doing it.
> First you introduce a new function with the arguments changed
> as you like.
> 
> Second you move all calls over to the new function.
> 
> Third you kill off the old function - sometimes you also do an easily
> verified rename of all functions at once.
> 
> How the last patch gets applied is rather dependent on what it touches.
> If just a couple of subsystems, then the maintainers tend to agree on who
> is taking the series and if useful they create an immutable branch which
> can then be pulled into any trees that need the change.  Doesn't matter
> who ends up sending the pull request to Linus as Git will sort it all out.
> 
> If it's really kernel wide, then you need to get in touch with Linus.
> Typically these are done at very specific points in the merge cycle - often
> either just before or just after rc1 I think.
> 
> Rafael did one of these whilst changing some stuff with power management
> kconfig dependencies in the last cycle.  It bit me because I was
> running a couple of months behind mainline, but mostly it went in
> without causing trouble.
> 
> Here, I'd probably just Ack the series and let Jiri pick it up and
> keep a vague eye open for possible merge conflicts later in the cycle.
> 
I already submitted new patchset taking care of this. I am submitting a
single patch to avoid bisect issues as you suggested in your comment for
the previous patch.

Thanks,
Srinivas 
> 
> Jonathan
> > 
> > 
> >> Thanks,
> >> Srinivas
> >>>
> >>> If you want to do things in steps, you'll have to carry to versions of
> >>> the function during the conversion and drop the unwanted one at the end.
> >>>
> >>>> ---
> >>>>   drivers/iio/accel/hid-sensor-accel-3d.c | 3 ++-
> >>>>   1 file changed, 2 insertions(+), 1 deletion(-)
> >>>>
> >>>> diff --git a/drivers/iio/accel/hid-sensor-accel-3d.c b/drivers/iio/accel/hid-sensor-accel-3d.c
> >>>> index d5d9531..0085c2f 100644
> >>>> --- a/drivers/iio/accel/hid-sensor-accel-3d.c
> >>>> +++ b/drivers/iio/accel/hid-sensor-accel-3d.c
> >>>> @@ -130,7 +130,8 @@ static int accel_3d_read_raw(struct iio_dev *indio_dev,
> >>>>               *val = sensor_hub_input_attr_get_raw_value(
> >>>>                       accel_state->common_attributes.hsdev,
> >>>>                       HID_USAGE_SENSOR_ACCEL_3D, address,
> >>>> -                    report_id);
> >>>> +                    report_id,
> >>>> +                    SENSOR_HUB_SYNC);
> >>>>           else {
> >>>>               *val = 0;
> >>>> hid_sensor_power_state(&accel_state->common_attributes,
> >>>>
> >>>
> >>
> > 
> 

[PATCH 3/9] iio: hid-sensor-gyro-3d: Adjust parameter for attribute read

[Srinivas Pandruvada]

The new API added a flag for sync/async mode. Added sync mode flag.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---
 drivers/iio/gyro/hid-sensor-gyro-3d.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/gyro/hid-sensor-gyro-3d.c b/drivers/iio/gyro/hid-sensor-gyro-3d.c
index a3ea1e8..bdcd105 100644
--- a/drivers/iio/gyro/hid-sensor-gyro-3d.c
+++ b/drivers/iio/gyro/hid-sensor-gyro-3d.c
@@ -130,7 +130,8 @@ static int gyro_3d_read_raw(struct iio_dev *indio_dev,
 			*val = sensor_hub_input_attr_get_raw_value(
 					gyro_state->common_attributes.hsdev,
 					HID_USAGE_SENSOR_GYRO_3D, address,
-					report_id);
+					report_id,
+					SENSOR_HUB_SYNC);
 		else {
 			*val = 0;
 			hid_sensor_power_state(&gyro_state->common_attributes,
-- 
1.9.3

[PATCH 4/9] iio: hid-sensor-als: Adjust parameter for attribute read

[Srinivas Pandruvada]

The new API added a flag for sync/async mode. Added sync mode flag.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---
 drivers/iio/light/hid-sensor-als.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/light/hid-sensor-als.c b/drivers/iio/light/hid-sensor-als.c
index a5283d7..321862d 100644
--- a/drivers/iio/light/hid-sensor-als.c
+++ b/drivers/iio/light/hid-sensor-als.c
@@ -109,7 +109,8 @@ static int als_read_raw(struct iio_dev *indio_dev,
 			*val = sensor_hub_input_attr_get_raw_value(
 					als_state->common_attributes.hsdev,
 					HID_USAGE_SENSOR_ALS, address,
-					report_id);
+					report_id,
+					SENSOR_HUB_SYNC);
 			hid_sensor_power_state(&als_state->common_attributes,
 						false);
 		} else {
-- 
1.9.3

[PATCH 1/9] HID: hid-sensor-hub: Extend API for async reads

[Srinivas Pandruvada]

Add additional flag to read in async mode. In this mode the caller
need to register for events and match attribute usage id for result.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
---
 drivers/hid/hid-sensor-hub.c   | 15 ++++++++++++++-
 include/linux/hid-sensor-hub.h | 19 +++++++++++++------
 2 files changed, 27 insertions(+), 7 deletions(-)

diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c
index 8bed109..7403b25 100644
--- a/drivers/hid/hid-sensor-hub.c
+++ b/drivers/hid/hid-sensor-hub.c
@@ -275,13 +275,26 @@ EXPORT_SYMBOL_GPL(sensor_hub_get_feature);
 
 int sensor_hub_input_attr_get_raw_value(struct hid_sensor_hub_device *hsdev,
 					u32 usage_id,
-					u32 attr_usage_id, u32 report_id)
+					u32 attr_usage_id, u32 report_id,
+					enum sensor_hub_read_flags flag)
 {
 	struct sensor_hub_data *data = hid_get_drvdata(hsdev->hdev);
 	unsigned long flags;
 	struct hid_report *report;
 	int ret_val = 0;
 
+	if (flag == SENSOR_HUB_ASYNC) {
+		report = sensor_hub_report(report_id, hsdev->hdev,
+					   HID_INPUT_REPORT);
+		if (!report)
+			return -EINVAL;
+
+		mutex_lock(&data->mutex);
+		hid_hw_request(hsdev->hdev, report, HID_REQ_GET_REPORT);
+		mutex_unlock(&data->mutex);
+		return 0;
+	}
+
 	mutex_lock(&hsdev->mutex);
 	memset(&hsdev->pending, 0, sizeof(hsdev->pending));
 	init_completion(&hsdev->pending.ready);
diff --git a/include/linux/hid-sensor-hub.h b/include/linux/hid-sensor-hub.h
index a51c768..d48e91f 100644
--- a/include/linux/hid-sensor-hub.h
+++ b/include/linux/hid-sensor-hub.h
@@ -171,20 +171,27 @@ int sensor_hub_input_get_attribute_info(struct hid_sensor_hub_device *hsdev,
 			struct hid_sensor_hub_attribute_info *info);
 
 /**
-* sensor_hub_input_attr_get_raw_value() - Synchronous read request
+* sensor_hub_input_attr_get_raw_value() - Attribute read request
 * @hsdev:	Hub device instance.
 * @usage_id:	Attribute usage id of parent physical device as per spec
 * @attr_usage_id:	Attribute usage id as per spec
 * @report_id:	Report id to look for
+* @flag:	Synchronour or asynchronous read
 *
-* Issues a synchronous read request for an input attribute. Returns
-* data upto 32 bits. Since client can get events, so this call should
-* not be used for data paths, this will impact performance.
+* Issues a synchronous or asynchronous read request for an input attribute.
+* Returns data upto 32 bits.
 */
 
+enum sensor_hub_read_flags {
+	SENSOR_HUB_SYNC,
+	SENSOR_HUB_ASYNC,
+};
+
 int sensor_hub_input_attr_get_raw_value(struct hid_sensor_hub_device *hsdev,
-			u32 usage_id,
-			u32 attr_usage_id, u32 report_id);
+					u32 usage_id,
+					u32 attr_usage_id, u32 report_id,
+					enum sensor_hub_read_flags flag
+);
 /**
 * sensor_hub_set_feature() - Feature set request
 * @hsdev:	Hub device instance.
-- 
1.9.3

Re: [PATCH 1/9] HID: hid-sensor-hub: Extend API for async reads

[Jonathan Cameron]

On 07/01/15 18:47, Srinivas Pandruvada wrote:
> Add additional flag to read in async mode. In this mode the caller
> need to register for events and match attribute usage id for result.
An example of this being used would make ti easier to see how it is meant
to work...
> 
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> ---
>  drivers/hid/hid-sensor-hub.c   | 15 ++++++++++++++-
>  include/linux/hid-sensor-hub.h | 19 +++++++++++++------
>  2 files changed, 27 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c
> index 8bed109..7403b25 100644
> --- a/drivers/hid/hid-sensor-hub.c
> +++ b/drivers/hid/hid-sensor-hub.c
> @@ -275,13 +275,26 @@ EXPORT_SYMBOL_GPL(sensor_hub_get_feature);
>  
>  int sensor_hub_input_attr_get_raw_value(struct hid_sensor_hub_device *hsdev,
>  					u32 usage_id,
> -					u32 attr_usage_id, u32 report_id)
> +					u32 attr_usage_id, u32 report_id,
> +					enum sensor_hub_read_flags flag)
>  {
>  	struct sensor_hub_data *data = hid_get_drvdata(hsdev->hdev);
>  	unsigned long flags;
>  	struct hid_report *report;
>  	int ret_val = 0;
>  
> +	if (flag == SENSOR_HUB_ASYNC) {
> +		report = sensor_hub_report(report_id, hsdev->hdev,
> +					   HID_INPUT_REPORT);
> +		if (!report)
> +			return -EINVAL;
> +
> +		mutex_lock(&data->mutex);
> +		hid_hw_request(hsdev->hdev, report, HID_REQ_GET_REPORT);
> +		mutex_unlock(&data->mutex);
> +		return 0;
> +	}
> +
>  	mutex_lock(&hsdev->mutex);
>  	memset(&hsdev->pending, 0, sizeof(hsdev->pending));
>  	init_completion(&hsdev->pending.ready);
> diff --git a/include/linux/hid-sensor-hub.h b/include/linux/hid-sensor-hub.h
> index a51c768..d48e91f 100644
> --- a/include/linux/hid-sensor-hub.h
> +++ b/include/linux/hid-sensor-hub.h
> @@ -171,20 +171,27 @@ int sensor_hub_input_get_attribute_info(struct hid_sensor_hub_device *hsdev,
>  			struct hid_sensor_hub_attribute_info *info);
>  
>  /**
> -* sensor_hub_input_attr_get_raw_value() - Synchronous read request
> +* sensor_hub_input_attr_get_raw_value() - Attribute read request
>  * @hsdev:	Hub device instance.
>  * @usage_id:	Attribute usage id of parent physical device as per spec
>  * @attr_usage_id:	Attribute usage id as per spec
>  * @report_id:	Report id to look for
> +* @flag:	Synchronour or asynchronous read
>  *
> -* Issues a synchronous read request for an input attribute. Returns
> -* data upto 32 bits. Since client can get events, so this call should
> -* not be used for data paths, this will impact performance.
> +* Issues a synchronous or asynchronous read request for an input attribute.
> +* Returns data upto 32 bits.
>  */
>  
> +enum sensor_hub_read_flags {
> +	SENSOR_HUB_SYNC,
> +	SENSOR_HUB_ASYNC,
> +};
> +
>  int sensor_hub_input_attr_get_raw_value(struct hid_sensor_hub_device *hsdev,
> -			u32 usage_id,
> -			u32 attr_usage_id, u32 report_id);
> +					u32 usage_id,
> +					u32 attr_usage_id, u32 report_id,
> +					enum sensor_hub_read_flags flag
> +);
>  /**
>  * sensor_hub_set_feature() - Feature set request
>  * @hsdev:	Hub device instance.
> 

[PATCH 5/9] iio: hid-sensor-prox: Adjust parameter for attribute read

[Srinivas Pandruvada]

The new API added a flag for sync/async mode. Added sync mode flag.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
---
 drivers/iio/light/hid-sensor-prox.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/light/hid-sensor-prox.c b/drivers/iio/light/hid-sensor-prox.c
index f5a5146..db9c60e 100644
--- a/drivers/iio/light/hid-sensor-prox.c
+++ b/drivers/iio/light/hid-sensor-prox.c
@@ -105,7 +105,8 @@ static int prox_read_raw(struct iio_dev *indio_dev,
 			*val = sensor_hub_input_attr_get_raw_value(
 				prox_state->common_attributes.hsdev,
 				HID_USAGE_SENSOR_PROX, address,
-				report_id);
+				report_id,
+				SENSOR_HUB_SYNC);
 			hid_sensor_power_state(&prox_state->common_attributes,
 						false);
 		} else {
-- 
1.9.3

[PATCH 6/9] iio: hid-sensor-magn-3d: Adjust parameter for attribute read

[Srinivas Pandruvada]

The new API added a flag for sync/async mode. Added sync mode flag.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
---
 drivers/iio/magnetometer/hid-sensor-magn-3d.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/magnetometer/hid-sensor-magn-3d.c b/drivers/iio/magnetometer/hid-sensor-magn-3d.c
index 6294575..4d299f3 100644
--- a/drivers/iio/magnetometer/hid-sensor-magn-3d.c
+++ b/drivers/iio/magnetometer/hid-sensor-magn-3d.c
@@ -178,7 +178,8 @@ static int magn_3d_read_raw(struct iio_dev *indio_dev,
 			*val = sensor_hub_input_attr_get_raw_value(
 				magn_state->common_attributes.hsdev,
 				HID_USAGE_SENSOR_COMPASS_3D, address,
-				report_id);
+				report_id,
+				SENSOR_HUB_SYNC);
 		else {
 			*val = 0;
 			hid_sensor_power_state(&magn_state->common_attributes,
-- 
1.9.3

[PATCH 8/9] iio: hid-sensor-press: Adjust parameter for attribute read

[Srinivas Pandruvada]

The new API added a flag for sync/async mode. Added sync mode flag.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
---
 drivers/iio/pressure/hid-sensor-press.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/pressure/hid-sensor-press.c b/drivers/iio/pressure/hid-sensor-press.c
index 7649286..ac150f0 100644
--- a/drivers/iio/pressure/hid-sensor-press.c
+++ b/drivers/iio/pressure/hid-sensor-press.c
@@ -108,7 +108,8 @@ static int press_read_raw(struct iio_dev *indio_dev,
 			*val = sensor_hub_input_attr_get_raw_value(
 				press_state->common_attributes.hsdev,
 				HID_USAGE_SENSOR_PRESSURE, address,
-				report_id);
+				report_id,
+				SENSOR_HUB_SYNC);
 			hid_sensor_power_state(&press_state->common_attributes,
 						false);
 		} else {
-- 
1.9.3

[PATCH 9/9] drivers/rtc/rtc-hid-sensor-time.c: Adjust parameter for attribute read

[Srinivas Pandruvada]

The new API added a flag for sync/async mode. Added sync mode flag.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
---
 drivers/rtc/rtc-hid-sensor-time.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rtc/rtc-hid-sensor-time.c b/drivers/rtc/rtc-hid-sensor-time.c
index ae7c2ba..af4f85a 100644
--- a/drivers/rtc/rtc-hid-sensor-time.c
+++ b/drivers/rtc/rtc-hid-sensor-time.c
@@ -213,7 +213,7 @@ static int hid_rtc_read_time(struct device *dev, struct rtc_time *tm)
 	/* get a report with all values through requesting one value */
 	sensor_hub_input_attr_get_raw_value(time_state->common_attributes.hsdev,
 			HID_USAGE_SENSOR_TIME, hid_time_addresses[0],
-			time_state->info[0].report_id);
+			time_state->info[0].report_id, SENSOR_HUB_SYNC);
 	/* wait for all values (event) */
 	ret = wait_for_completion_killable_timeout(
 			&time_state->comp_last_time, HZ*6);
-- 
1.9.3

[PATCH 7/9] iio: hid-sensor-incl-3d: Adjust parameter for attribute read

[Srinivas Pandruvada]

The new API added a flag for sync/async mode. Added sync mode flag.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---
 drivers/iio/orientation/hid-sensor-incl-3d.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/orientation/hid-sensor-incl-3d.c b/drivers/iio/orientation/hid-sensor-incl-3d.c
index 1ff181b..45bed08 100644
--- a/drivers/iio/orientation/hid-sensor-incl-3d.c
+++ b/drivers/iio/orientation/hid-sensor-incl-3d.c
@@ -132,7 +132,8 @@ static int incl_3d_read_raw(struct iio_dev *indio_dev,
 			*val = sensor_hub_input_attr_get_raw_value(
 				incl_state->common_attributes.hsdev,
 				HID_USAGE_SENSOR_INCLINOMETER_3D, address,
-				report_id);
+				report_id,
+				SENSOR_HUB_SYNC);
 		else {
 			hid_sensor_power_state(&incl_state->common_attributes,
 						false);
-- 
1.9.3

[PATCH] HID: hid-sensor-hub: Correct documentation

[Srinivas Pandruvada]

During changes to the interface, some documentation field comments
were missed. Added missing comments.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---
 include/linux/hid-sensor-hub.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/include/linux/hid-sensor-hub.h b/include/linux/hid-sensor-hub.h
index 51f7cca..4173a8f 100644
--- a/include/linux/hid-sensor-hub.h
+++ b/include/linux/hid-sensor-hub.h
@@ -33,6 +33,8 @@
  * @units:		Measurment unit for this attribute.
  * @unit_expo:		Exponent used in the data.
  * @size:		Size in bytes for data size.
+ * @logical_minimum:	Logical minimum value for this attribute.
+ * @logical_maximum:	Logical maximum value for this attribute.
  */
 struct hid_sensor_hub_attribute_info {
 	u32 usage_id;
@@ -146,6 +148,7 @@ int sensor_hub_input_get_attribute_info(struct hid_sensor_hub_device *hsdev,
 
 /**
 * sensor_hub_input_attr_get_raw_value() - Synchronous read request
+* @hsdev:	Hub device instance.
 * @usage_id:	Attribute usage id of parent physical device as per spec
 * @attr_usage_id:	Attribute usage id as per spec
 * @report_id:	Report id to look for
@@ -160,6 +163,7 @@ int sensor_hub_input_attr_get_raw_value(struct hid_sensor_hub_device *hsdev,
 			u32 attr_usage_id, u32 report_id);
 /**
 * sensor_hub_set_feature() - Feature set request
+* @hsdev:	Hub device instance.
 * @report_id:	Report id to look for
 * @field_index:	Field index inside a report
 * @value:	Value to set
@@ -172,6 +176,7 @@ int sensor_hub_set_feature(struct hid_sensor_hub_device *hsdev, u32 report_id,
 
 /**
 * sensor_hub_get_feature() - Feature get request
+* @hsdev:	Hub device instance.
 * @report_id:	Report id to look for
 * @field_index:	Field index inside a report
 * @value:	Place holder for return value
-- 
1.9.1

[PATCH 5/9] iio: hid-sensor-prox: Adjust parameter for attribute read

[Srinivas Pandruvada]

The new API added a flag for sync/async mode. Added sync mode flag.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---
 drivers/iio/light/hid-sensor-prox.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/light/hid-sensor-prox.c b/drivers/iio/light/hid-sensor-prox.c
index f5a5146..db9c60e 100644
--- a/drivers/iio/light/hid-sensor-prox.c
+++ b/drivers/iio/light/hid-sensor-prox.c
@@ -105,7 +105,8 @@ static int prox_read_raw(struct iio_dev *indio_dev,
 			*val = sensor_hub_input_attr_get_raw_value(
 				prox_state->common_attributes.hsdev,
 				HID_USAGE_SENSOR_PROX, address,
-				report_id);
+				report_id,
+				SENSOR_HUB_SYNC);
 			hid_sensor_power_state(&prox_state->common_attributes,
 						false);
 		} else {
-- 
1.9.1