[PATCH 8/8] Coding Style Correction.

[PATCH 8/8] Coding Style Correction.

[Shailendra Verma]

Signed-off-by: Shailendra Verma <shailendra.capricorn@gmail.com>
---
 drivers/input/evdev.c    |   30 ++++++++++++++++++++----------
 drivers/input/mousedev.c |   18 ++++++++++++------
 2 files changed, 32 insertions(+), 16 deletions(-)

diff --git a/drivers/input/evdev.c b/drivers/input/evdev.c
index 18d4b2c..85ee594 100644
--- a/drivers/input/evdev.c
+++ b/drivers/input/evdev.c
@@ -667,16 +667,26 @@ static int handle_eviocgbit(struct input_dev *dev,
 
 	switch (type) {
 
-	case      0: bits = dev->evbit;  len = EV_MAX;  break;
-	case EV_KEY: bits = dev->keybit; len = KEY_MAX; break;
-	case EV_REL: bits = dev->relbit; len = REL_MAX; break;
-	case EV_ABS: bits = dev->absbit; len = ABS_MAX; break;
-	case EV_MSC: bits = dev->mscbit; len = MSC_MAX; break;
-	case EV_LED: bits = dev->ledbit; len = LED_MAX; break;
-	case EV_SND: bits = dev->sndbit; len = SND_MAX; break;
-	case EV_FF:  bits = dev->ffbit;  len = FF_MAX;  break;
-	case EV_SW:  bits = dev->swbit;  len = SW_MAX;  break;
-	default: return -EINVAL;
+	case      0:
+		bits = dev->evbit;  len = EV_MAX;  break;
+	case EV_KEY:
+		bits = dev->keybit; len = KEY_MAX; break;
+	case EV_REL:
+		bits = dev->relbit; len = REL_MAX; break;
+	case EV_ABS:
+		bits = dev->absbit; len = ABS_MAX; break;
+	case EV_MSC:
+		bits = dev->mscbit; len = MSC_MAX; break;
+	case EV_LED:
+		bits = dev->ledbit; len = LED_MAX; break;
+	case EV_SND:
+		bits = dev->sndbit; len = SND_MAX; break;
+	case EV_FF:
+		bits = dev->ffbit;  len = FF_MAX;  break;
+	case EV_SW:
+		bits = dev->swbit;  len = SW_MAX;  break;
+	default:
+		return -EINVAL;
 	}
 
 	return bits_to_user(bits, len, size, p, compat_mode);
diff --git a/drivers/input/mousedev.c b/drivers/input/mousedev.c
index b604564..a9857dd 100644
--- a/drivers/input/mousedev.c
+++ b/drivers/input/mousedev.c
@@ -230,25 +230,31 @@ static void mousedev_key_event(struct mousedev *mousedev,
 
 	case BTN_TOUCH:
 	case BTN_0:
-	case BTN_LEFT:		index = 0; break;
+	case BTN_LEFT:
+		index = 0; break;
 
 	case BTN_STYLUS:
 	case BTN_1:
-	case BTN_RIGHT:		index = 1; break;
+	case BTN_RIGHT:
+		index = 1; break;
 
 	case BTN_2:
 	case BTN_FORWARD:
 	case BTN_STYLUS2:
-	case BTN_MIDDLE:	index = 2; break;
+	case BTN_MIDDLE:
+		index = 2; break;
 
 	case BTN_3:
 	case BTN_BACK:
-	case BTN_SIDE:		index = 3; break;
+	case BTN_SIDE:
+		index = 3; break;
 
 	case BTN_4:
-	case BTN_EXTRA:		index = 4; break;
+	case BTN_EXTRA:
+		index = 4; break;
 
-	default:		return;
+	default:
+		return;
 	}
 
 	if (value) {
-- 
1.7.9.5

Re: [PATCH 8/8] Coding Style Correction.

[Jeremiah Mahler]

Shailendra,

Please describe in detail which specific coding issues you fixed.
I am not good at reading minds :-)

Also, this is patch 8/8, and I see there is a 2/2, (which also needs
a better description).  Where are the rest of the patches?

On Sat, Jan 17, 2015 at 01:28:49PM +0530, Shailendra Verma wrote:
> 
> Signed-off-by: Shailendra Verma <shailendra.capricorn@gmail.com>
> ---
>  drivers/input/evdev.c    |   30 ++++++++++++++++++++----------
>  drivers/input/mousedev.c |   18 ++++++++++++------
>  2 files changed, 32 insertions(+), 16 deletions(-)
[...]

-- 
- Jeremiah Mahler

Re: [PATCH 8/8] Coding Style Correction.

[Jeremiah Mahler]

Shailendra,

On Sat, Jan 17, 2015 at 03:51:49PM +0530, Shailendra Verma wrote:
> Hello Mahler,
> 
> I have just changed the coding style violations in this patch as described
> in the coding style Linux Documentation.
> 
Be specific about exactly what type of violation you fixed.
Was it white space fixes?  Was it indentation of cases statements?

> Thanks & Regards,
> Shailendra
> On Jan 17, 2015 3:45 PM, "Jeremiah Mahler" <jmmahler@gmail.com> wrote:
> 
> > Shailendra,
> >
> > Please describe in detail which specific coding issues you fixed.
> > I am not good at reading minds :-)
> >
> > Also, this is patch 8/8, and I see there is a 2/2, (which also needs
> > a better description).  Where are the rest of the patches?
> >
> > On Sat, Jan 17, 2015 at 01:28:49PM +0530, Shailendra Verma wrote:
> > >
> > > Signed-off-by: Shailendra Verma <shailendra.capricorn@gmail.com>
> > > ---
> > >  drivers/input/evdev.c    |   30 ++++++++++++++++++++----------
> > >  drivers/input/mousedev.c |   18 ++++++++++++------
> > >  2 files changed, 32 insertions(+), 16 deletions(-)
> > [...]
> >
> > --
> > - Jeremiah Mahler
> >

-- 
- Jeremiah Mahler

Re: [PATCH 8/8] Coding Style Correction.

[Jeremiah Mahler]

On Sat, Jan 17, 2015 at 04:43:01PM +0530, Shailendra Verma wrote:
> Hello Mahler,
> 
> I have fixed indentation violation in switch statement : aligned the
> "switch" and its subordinate "case" labels in the same column instead of
> "double-intending" the "case" labels.
> 
It is looking better.  Now put this in the patch log message and send
version 2.

> Thanks & Regards,
> Shailendra
> On Jan 17, 2015 4:28 PM, "Jeremiah Mahler" <jmmahler@gmail.com> wrote:
> 
> > Shailendra,
> >
[...]

-- 
- Jeremiah Mahler