From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Henrik Rydberg <rydberg@euromail.se>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Hans de Goede <hdegoede@redhat.com>
Cc: Peter Hutterer <peter.hutterer@who-t.net>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [RFC 1/6] Input: mt: make input_mt_assign_slots() a little bit more readable
Date: Mon, 19 Jan 2015 15:53:50 -0500 [thread overview]
Message-ID: <1421700835-22157-2-git-send-email-benjamin.tissoires@redhat.com> (raw)
In-Reply-To: <1421700835-22157-1-git-send-email-benjamin.tissoires@redhat.com>
Rename "nrc" into "n_elems" and explicitly name the number of
rows and the number of columns.
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
---
drivers/input/input-mt.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/input/input-mt.c b/drivers/input/input-mt.c
index fbe29fc..b6ee42a 100644
--- a/drivers/input/input-mt.c
+++ b/drivers/input/input-mt.c
@@ -404,7 +404,7 @@ int input_mt_assign_slots(struct input_dev *dev, int *slots,
const struct input_mt_pos *pos, int num_pos)
{
struct input_mt *mt = dev->mt;
- int nrc;
+ int n_elems, n_rows, n_columns;
if (!mt || !mt->red)
return -ENXIO;
@@ -413,8 +413,10 @@ int input_mt_assign_slots(struct input_dev *dev, int *slots,
if (num_pos < 1)
return 0;
- nrc = input_mt_set_matrix(mt, pos, num_pos);
- find_reduced_matrix(mt->red, num_pos, nrc / num_pos, nrc);
+ n_elems = input_mt_set_matrix(mt, pos, num_pos);
+ n_rows = n_elems / num_pos;
+ n_columns = num_pos;
+ find_reduced_matrix(mt->red, n_columns, n_rows, n_elems);
input_mt_set_slots(mt, slots, num_pos);
return 0;
--
2.1.0
next prev parent reply other threads:[~2015-01-19 20:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-19 20:53 [RFC 0/6] Input: mt: Document in-kernel tracking and solve jumping cursors issues Benjamin Tissoires
2015-01-19 20:53 ` Benjamin Tissoires [this message]
2015-01-19 20:53 ` [RFC 2/6] Input: mt: Document input_mt_set_slots() Benjamin Tissoires
2015-01-19 20:53 ` [RFC 3/6] Input: mt: document input_mt_set_matrix() Benjamin Tissoires
2015-01-19 20:53 ` [RFC 4/6] Input: mt: document find_reduced_matrix() Benjamin Tissoires
2015-01-19 20:53 ` [RFC 5/6] Input: mt: document adjust_dual() Benjamin Tissoires
2015-01-19 20:53 ` [RFC 6/6] Input: mt: introduce dmax in in-kernel tracking Benjamin Tissoires
2015-01-19 21:03 ` Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421700835-22157-2-git-send-email-benjamin.tissoires@redhat.com \
--to=benjamin.tissoires@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.hutterer@who-t.net \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).