From: Daniel Martin <daniel.martin@secunet.com>
To: linux-input@vger.kernel.org
Cc: Daniel Martin <consume.noise@gmail.com>
Subject: [PATCH 2/6] Input: synaptics - Log queried and quirked dimension values
Date: Thu, 22 Jan 2015 17:46:37 +0100 [thread overview]
Message-ID: <1421945201-1528-3-git-send-email-daniel.martin@secunet.com> (raw)
In-Reply-To: <1421945201-1528-1-git-send-email-daniel.martin@secunet.com>
From: Daniel Martin <consume.noise@gmail.com>
Logging the dimension values we queried (info) and the values we use
from a quirk to overwrite (warn) can be helpful for debugging.
This partly relates to bug:
https://bugzilla.kernel.org/show_bug.cgi?id=91541
Signed-off-by: Daniel Martin <consume.noise@gmail.com>
---
drivers/input/mouse/synaptics.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index 88f02aa..e2b4f5a 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -361,6 +361,10 @@ static int synaptics_resolution(struct psmouse *psmouse)
} else {
priv->x_max = (resp[0] << 5) | ((resp[1] & 0x0f) << 1);
priv->y_max = (resp[2] << 5) | ((resp[1] & 0xf0) >> 3);
+ psmouse_info(psmouse,
+ "queried max coordinates: "
+ "x [..%d], y [..%d]\n",
+ priv->x_max, priv->y_max);
}
}
@@ -372,6 +376,10 @@ static int synaptics_resolution(struct psmouse *psmouse)
} else {
priv->x_min = (resp[0] << 5) | ((resp[1] & 0x0f) << 1);
priv->y_min = (resp[2] << 5) | ((resp[1] & 0xf0) >> 3);
+ psmouse_info(psmouse,
+ "queried min coordinates: "
+ "x [%d..], y [%d..]\n",
+ priv->x_min, priv->y_min);
}
}
@@ -397,6 +405,11 @@ static int synaptics_quirks(struct psmouse *psmouse)
priv->x_max = min_max_pnpid_table[i].x_max;
priv->y_min = min_max_pnpid_table[i].y_min;
priv->y_max = min_max_pnpid_table[i].y_max;
+ psmouse_warn(psmouse,
+ "quirked min/max coordinates: "
+ "x [%d..%d], y [%d..%d]\n",
+ priv->x_min, priv->x_max,
+ priv->y_min, priv->y_max);
break;
}
}
--
2.2.2
next prev parent reply other threads:[~2015-01-22 16:41 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 16:46 synaptics: match PNP-Id is not sufficient for min/max quirks Daniel Martin
2015-01-22 16:46 ` [PATCH 1/6] Input: synaptics - Split synaptics_resolution(), query first Daniel Martin
2015-01-22 16:46 ` Daniel Martin [this message]
2015-01-22 16:46 ` [PATCH 3/6] Input: synaptics - Query min dimensions when safe firmware Daniel Martin
2015-01-22 16:46 ` [PATCH 4/6] Input: synaptics - Skip quirks when post-2013 dimensions Daniel Martin
2015-01-22 16:46 ` [PATCH 5/6] Input: synaptics - Add PnP id for X1 Carbon 1nd Daniel Martin
2015-01-23 8:42 ` Daniel Martin
2015-01-23 13:40 ` Daniel Martin
2015-01-22 16:46 ` [PATCH 6/6] Input: synaptics - Remove obsolete min/max quirk for X240 Daniel Martin
2015-01-27 8:34 ` [v2] synaptics: match PNP-Id is not sufficient for min/max quirks Daniel Martin
2015-01-27 8:34 ` [PATCH v2 1/5] Input: synaptics - Split synaptics_resolution(), query first Daniel Martin
2015-01-27 8:34 ` [PATCH v2 2/5] Input: synaptics - Log queried and quirked dimension values Daniel Martin
2015-01-27 8:34 ` [PATCH v2 3/5] Input: synaptics - Query min dimensions when safe firmware Daniel Martin
2015-01-29 18:48 ` Benjamin Tissoires
2015-01-30 9:03 ` Hans de Goede
2015-01-30 15:41 ` Benjamin Tissoires
2015-01-30 22:35 ` Andrew Duggan
2015-01-31 8:11 ` Daniel Martin
2015-01-27 8:34 ` [PATCH v2 4/5] Input: synaptics - Skip quirks when post-2013 dimensions Daniel Martin
2015-01-29 19:02 ` Benjamin Tissoires
2015-01-29 19:50 ` Benjamin Tissoires
2015-01-30 9:59 ` Hans de Goede
2015-01-30 15:34 ` Benjamin Tissoires
2015-01-30 22:47 ` Andrew Duggan
2015-01-31 8:18 ` Daniel Martin
2015-02-05 21:22 ` Benjamin Tissoires
2015-02-07 8:02 ` Hans de Goede
2015-01-27 8:34 ` [PATCH v2 5/5] Input: synaptics - Remove obsolete min/max quirk for X240 Daniel Martin
2015-01-27 16:36 ` [v2] synaptics: match PNP-Id is not sufficient for min/max quirks Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421945201-1528-3-git-send-email-daniel.martin@secunet.com \
--to=daniel.martin@secunet.com \
--cc=consume.noise@gmail.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).