From: Daniel Martin <daniel.martin@secunet.com>
To: linux-input@vger.kernel.org
Cc: Daniel Martin <consume.noise@gmail.com>
Subject: [PATCH 3/6] Input: synaptics - Query min dimensions when safe firmware
Date: Thu, 22 Jan 2015 17:46:38 +0100 [thread overview]
Message-ID: <1421945201-1528-4-git-send-email-daniel.martin@secunet.com> (raw)
In-Reply-To: <1421945201-1528-1-git-send-email-daniel.martin@secunet.com>
From: Daniel Martin <consume.noise@gmail.com>
Query the min dimensions even if the check
SYN_EXT_CAP_REQUESTS(priv->capabilities) >= 7
fails, but we know that the firmware version is safe. Atm. this is
version 8.1 only.
With that we don't need quirks for post-2013 models anymore as they
expose correct min and max dimensions.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=91541
Signed-off-by: Daniel Martin <consume.noise@gmail.com>
---
drivers/input/mouse/synaptics.c | 27 ++++++++++++++++++++++++++-
1 file changed, 26 insertions(+), 1 deletion(-)
diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index e2b4f5a..8ed4760 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -333,6 +333,30 @@ static int synaptics_identify(struct psmouse *psmouse)
return -1;
}
+struct fw_version {
+ unsigned char major;
+ unsigned char minor;
+};
+
+static const struct fw_version safe_fw_list[] = {
+ {8, 1}, /* safe for SYN_QUE_EXT_MIN_COORDS */
+ { }
+};
+
+static bool synaptics_is_safe_fw(struct psmouse *psmouse)
+{
+ struct synaptics_data *priv = psmouse->private;
+ int i;
+
+ for (i = 0; safe_fw_list[i].major; i++) {
+ if (safe_fw_list[i].major == SYN_ID_MAJOR(priv->identity) &&
+ safe_fw_list[i].minor == SYN_ID_MINOR(priv->identity))
+ return true;
+ }
+
+ return false;
+}
+
/*
* Read touchpad resolution and maximum reported coordinates
* Resolution is left zero if touchpad does not support the query
@@ -368,7 +392,8 @@ static int synaptics_resolution(struct psmouse *psmouse)
}
}
- if (SYN_EXT_CAP_REQUESTS(priv->capabilities) >= 7 &&
+ if ((SYN_EXT_CAP_REQUESTS(priv->capabilities) >= 7 ||
+ synaptics_is_safe_fw(psmouse)) &&
SYN_CAP_MIN_DIMENSIONS(priv->ext_cap_0c)) {
if (synaptics_send_cmd(psmouse, SYN_QUE_EXT_MIN_COORDS, resp)) {
psmouse_warn(psmouse,
--
2.2.2
next prev parent reply other threads:[~2015-01-22 16:41 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 16:46 synaptics: match PNP-Id is not sufficient for min/max quirks Daniel Martin
2015-01-22 16:46 ` [PATCH 1/6] Input: synaptics - Split synaptics_resolution(), query first Daniel Martin
2015-01-22 16:46 ` [PATCH 2/6] Input: synaptics - Log queried and quirked dimension values Daniel Martin
2015-01-22 16:46 ` Daniel Martin [this message]
2015-01-22 16:46 ` [PATCH 4/6] Input: synaptics - Skip quirks when post-2013 dimensions Daniel Martin
2015-01-22 16:46 ` [PATCH 5/6] Input: synaptics - Add PnP id for X1 Carbon 1nd Daniel Martin
2015-01-23 8:42 ` Daniel Martin
2015-01-23 13:40 ` Daniel Martin
2015-01-22 16:46 ` [PATCH 6/6] Input: synaptics - Remove obsolete min/max quirk for X240 Daniel Martin
2015-01-27 8:34 ` [v2] synaptics: match PNP-Id is not sufficient for min/max quirks Daniel Martin
2015-01-27 8:34 ` [PATCH v2 1/5] Input: synaptics - Split synaptics_resolution(), query first Daniel Martin
2015-01-27 8:34 ` [PATCH v2 2/5] Input: synaptics - Log queried and quirked dimension values Daniel Martin
2015-01-27 8:34 ` [PATCH v2 3/5] Input: synaptics - Query min dimensions when safe firmware Daniel Martin
2015-01-29 18:48 ` Benjamin Tissoires
2015-01-30 9:03 ` Hans de Goede
2015-01-30 15:41 ` Benjamin Tissoires
2015-01-30 22:35 ` Andrew Duggan
2015-01-31 8:11 ` Daniel Martin
2015-01-27 8:34 ` [PATCH v2 4/5] Input: synaptics - Skip quirks when post-2013 dimensions Daniel Martin
2015-01-29 19:02 ` Benjamin Tissoires
2015-01-29 19:50 ` Benjamin Tissoires
2015-01-30 9:59 ` Hans de Goede
2015-01-30 15:34 ` Benjamin Tissoires
2015-01-30 22:47 ` Andrew Duggan
2015-01-31 8:18 ` Daniel Martin
2015-02-05 21:22 ` Benjamin Tissoires
2015-02-07 8:02 ` Hans de Goede
2015-01-27 8:34 ` [PATCH v2 5/5] Input: synaptics - Remove obsolete min/max quirk for X240 Daniel Martin
2015-01-27 16:36 ` [v2] synaptics: match PNP-Id is not sufficient for min/max quirks Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421945201-1528-4-git-send-email-daniel.martin@secunet.com \
--to=daniel.martin@secunet.com \
--cc=consume.noise@gmail.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).