* [PATCH 1/2] Input: drv260x - Remove wrong and unneeded drv260x-haptics modalias
@ 2015-01-31 5:20 Axel Lin
2015-01-31 5:21 ` [PATCH 2/2] Input: drv2667 - Remove wrong and unneeded drv2667-haptics modalias Axel Lin
0 siblings, 1 reply; 3+ messages in thread
From: Axel Lin @ 2015-01-31 5:20 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: Dan Murphy, linux-input@vger.kernel.org
This is a I2C driver, so it's wrong to use platform prefix for the modalias.
We have all needed i2c aliases coming form MODULE_DEVICE_TABLE,
so remove the wrong and unneeded drv260x-haptics modalias.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/input/misc/drv260x.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/input/misc/drv260x.c b/drivers/input/misc/drv260x.c
index a364e10..5995780 100644
--- a/drivers/input/misc/drv260x.c
+++ b/drivers/input/misc/drv260x.c
@@ -733,7 +733,6 @@ static struct i2c_driver drv260x_driver = {
};
module_i2c_driver(drv260x_driver);
-MODULE_ALIAS("platform:drv260x-haptics");
MODULE_DESCRIPTION("TI DRV260x haptics driver");
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Dan Murphy <dmurphy@ti.com>");
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH 2/2] Input: drv2667 - Remove wrong and unneeded drv2667-haptics modalias
2015-01-31 5:20 [PATCH 1/2] Input: drv260x - Remove wrong and unneeded drv260x-haptics modalias Axel Lin
@ 2015-01-31 5:21 ` Axel Lin
2015-02-01 4:21 ` Dmitry Torokhov
0 siblings, 1 reply; 3+ messages in thread
From: Axel Lin @ 2015-01-31 5:21 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: Dan Murphy, linux-input@vger.kernel.org
This is a I2C driver, so it's wrong to use platform prefix for the modalias.
We have all needed i2c aliases coming form MODULE_DEVICE_TABLE,
so remove the wrong and unneeded drv2667-haptics modalias.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/input/misc/drv2667.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/input/misc/drv2667.c b/drivers/input/misc/drv2667.c
index a021744..fc0fddf 100644
--- a/drivers/input/misc/drv2667.c
+++ b/drivers/input/misc/drv2667.c
@@ -492,7 +492,6 @@ static struct i2c_driver drv2667_driver = {
};
module_i2c_driver(drv2667_driver);
-MODULE_ALIAS("platform:drv2667-haptics");
MODULE_DESCRIPTION("TI DRV2667 haptics driver");
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Dan Murphy <dmurphy@ti.com>");
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 2/2] Input: drv2667 - Remove wrong and unneeded drv2667-haptics modalias
2015-01-31 5:21 ` [PATCH 2/2] Input: drv2667 - Remove wrong and unneeded drv2667-haptics modalias Axel Lin
@ 2015-02-01 4:21 ` Dmitry Torokhov
0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2015-02-01 4:21 UTC (permalink / raw)
To: Axel Lin; +Cc: Dan Murphy, linux-input@vger.kernel.org
On Sat, Jan 31, 2015 at 01:21:45PM +0800, Axel Lin wrote:
> This is a I2C driver, so it's wrong to use platform prefix for the modalias.
> We have all needed i2c aliases coming form MODULE_DEVICE_TABLE,
> so remove the wrong and unneeded drv2667-haptics modalias.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Applied both, thank you.
> ---
> drivers/input/misc/drv2667.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/input/misc/drv2667.c b/drivers/input/misc/drv2667.c
> index a021744..fc0fddf 100644
> --- a/drivers/input/misc/drv2667.c
> +++ b/drivers/input/misc/drv2667.c
> @@ -492,7 +492,6 @@ static struct i2c_driver drv2667_driver = {
> };
> module_i2c_driver(drv2667_driver);
>
> -MODULE_ALIAS("platform:drv2667-haptics");
> MODULE_DESCRIPTION("TI DRV2667 haptics driver");
> MODULE_LICENSE("GPL");
> MODULE_AUTHOR("Dan Murphy <dmurphy@ti.com>");
> --
> 1.9.1
>
>
>
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-02-01 4:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-31 5:20 [PATCH 1/2] Input: drv260x - Remove wrong and unneeded drv260x-haptics modalias Axel Lin
2015-01-31 5:21 ` [PATCH 2/2] Input: drv2667 - Remove wrong and unneeded drv2667-haptics modalias Axel Lin
2015-02-01 4:21 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).