From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Martin Subject: [PATCH 2/5] Input: synaptics - Log queried and quirked dimension values Date: Fri, 6 Feb 2015 14:25:05 +0100 Message-ID: <1423229108-29268-3-git-send-email-daniel.martin@secunet.com> References: <1423229108-29268-1-git-send-email-daniel.martin@secunet.com> Reply-To: Daniel Martin Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from a.mx.secunet.com ([195.81.216.161]:41581 "EHLO a.mx.secunet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754332AbbBFNT2 (ORCPT ); Fri, 6 Feb 2015 08:19:28 -0500 In-Reply-To: <1423229108-29268-1-git-send-email-daniel.martin@secunet.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, Hans de Goede , Benjamin Tissoires , Daniel Martin From: Daniel Martin Logging the dimension values we queried (info) and the values we use from a quirk to overwrite (warn) can be helpful for debugging. This partly relates to bug: https://bugzilla.kernel.org/show_bug.cgi?id=91541 Signed-off-by: Daniel Martin --- drivers/input/mouse/synaptics.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c index 89b408b..7a78d75 100644 --- a/drivers/input/mouse/synaptics.c +++ b/drivers/input/mouse/synaptics.c @@ -361,6 +361,10 @@ static int synaptics_resolution(struct psmouse *psmouse) } else { priv->x_max = (resp[0] << 5) | ((resp[1] & 0x0f) << 1); priv->y_max = (resp[2] << 5) | ((resp[1] & 0xf0) >> 3); + psmouse_info(psmouse, + "queried max coordinates: " + "x [..%d], y [..%d]\n", + priv->x_max, priv->y_max); } } @@ -372,6 +376,10 @@ static int synaptics_resolution(struct psmouse *psmouse) } else { priv->x_min = (resp[0] << 5) | ((resp[1] & 0x0f) << 1); priv->y_min = (resp[2] << 5) | ((resp[1] & 0xf0) >> 3); + psmouse_info(psmouse, + "queried min coordinates: " + "x [%d..], y [%d..]\n", + priv->x_min, priv->y_min); } } @@ -394,6 +402,11 @@ static int synaptics_quirks(struct psmouse *psmouse) priv->x_max = min_max_pnpid_table[i].x_max; priv->y_min = min_max_pnpid_table[i].y_min; priv->y_max = min_max_pnpid_table[i].y_max; + psmouse_warn(psmouse, + "quirked min/max coordinates: " + "x [%d..%d], y [%d..%d]\n", + priv->x_min, priv->x_max, + priv->y_min, priv->y_max); break; } } -- 2.2.2