linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Martin <daniel.martin@secunet.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>,
	Benjamin Tissoires <benjamin.tissoires@gmail.com>,
	Daniel Martin <consume.noise@gmail.com>
Subject: [PATCH 3/5] Input: synaptics - Query min dimensions for fw v8.1
Date: Fri, 6 Feb 2015 14:25:06 +0100	[thread overview]
Message-ID: <1423229108-29268-4-git-send-email-daniel.martin@secunet.com> (raw)
In-Reply-To: <1423229108-29268-1-git-send-email-daniel.martin@secunet.com>

From: Daniel Martin <consume.noise@gmail.com>

Query the min dimensions even if the check
    SYN_EXT_CAP_REQUESTS(priv->capabilities) >= 7
fails, but we know that the firmware version 8.1 is safe.

With that we don't need quirks for post-2013 models anymore as they
expose correct min and max dimensions.

v2: Don't use a list for safe firmwares.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=91541
Signed-off-by: Daniel Martin <consume.noise@gmail.com>
---
 drivers/input/mouse/synaptics.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index 7a78d75..0b7805c 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -368,8 +368,13 @@ static int synaptics_resolution(struct psmouse *psmouse)
 		}
 	}
 
-	if (SYN_EXT_CAP_REQUESTS(priv->capabilities) >= 7 &&
-	    SYN_CAP_MIN_DIMENSIONS(priv->ext_cap_0c)) {
+	if ((SYN_EXT_CAP_REQUESTS(priv->capabilities) >= 7 &&
+	     SYN_CAP_MIN_DIMENSIONS(priv->ext_cap_0c)) ||
+	    /* Firmware v8.1 doesn't stand the previous checks, though has
+	     * been proven to report correct min coordinates.
+	     *     https://bugzilla.kernel.org/show_bug.cgi?id=91541 */
+	    (SYN_ID_MAJOR(priv->identity) == 8 &&
+	     SYN_ID_MINOR(priv->identity) == 1)) {
 		if (synaptics_send_cmd(psmouse, SYN_QUE_EXT_MIN_COORDS, resp)) {
 			psmouse_warn(psmouse,
 				     "device claims to have min coordinates query, but I'm not able to read it.\n");
-- 
2.2.2


  parent reply	other threads:[~2015-02-06 13:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-06 13:25 [v3] synaptics: match PNP-Id is not sufficient for min/max quirks Daniel Martin
2015-02-06 13:25 ` [PATCH 1/5] Input: synaptics - Split synaptics_resolution(), query first Daniel Martin
2015-02-06 13:25 ` [PATCH 2/5] Input: synaptics - Log queried and quirked dimension values Daniel Martin
2015-02-06 13:25 ` Daniel Martin [this message]
2015-02-06 14:32   ` [PATCH 3/5] Input: synaptics - Query min dimensions for fw v8.1 Benjamin Tissoires
2015-02-06 13:25 ` [PATCH 4/5] Input: synaptics - Remove obsolete min/max quirk for X240 Daniel Martin
2015-02-06 13:25 ` [PATCH 5/5] Input: synaptics - Support min/max board id in min_max_pnpid_table Daniel Martin
2015-02-06 14:35 ` [v3] synaptics: match PNP-Id is not sufficient for min/max quirks Benjamin Tissoires

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1423229108-29268-4-git-send-email-daniel.martin@secunet.com \
    --to=daniel.martin@secunet.com \
    --cc=benjamin.tissoires@gmail.com \
    --cc=consume.noise@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).