From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH v3 04/20] power_supply: sysfs: Use power_supply_*() API for accessing function attrs Date: Tue, 10 Feb 2015 08:39:19 +0100 Message-ID: <1423553959.1327.1.camel@AMDC1943> References: <1422629278-12202-1-git-send-email-k.kozlowski@samsung.com> <1422629278-12202-5-git-send-email-k.kozlowski@samsung.com> <70066540.345820.1423508541546.JavaMail.open-xchange@oxbaltgw00.schlund.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <70066540.345820.1423508541546.JavaMail.open-xchange-h4m1HHXQYNHZ78VGacPtK8gmgJlYmuWJ@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stefan Wahren Cc: "H. Peter Anvin" , Linus Walleij , Dmitry Eremin-Solenikov , Support Opensource , Darren Hart , Robert Jarzmik , linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Samuel Ortiz , Lee Jones , ac100-oU9gvf+ajcQ97yFScArB1dHuzzzSOjJt@public.gmane.org, Cezary Jackiewicz , Russell King , patches-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org, Milo Kim , David Herrmann , devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org, Len Brown , linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ingo Molnar , linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Rafael J. Wysocki" , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Daniel Mack , platform-driver-x86-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Sebastian List-Id: linux-input@vger.kernel.org On pon, 2015-02-09 at 20:02 +0100, Stefan Wahren wrote: > Hi Krzysztof, > > > Krzysztof Kozlowski hat am 30. Januar 2015 um 15:47 > > geschrieben: > > > > > > Replace direct calls to power supply function attributes with wrappers. > > Wrappers provide safe access in case of unregistering the power > > supply (e.g. by removing the driver). Replace: > > - get_property -> power_supply_get_property > > - set_property -> power_supply_set_property > > - property_is_writeable -> power_supply_property_is_writeable > > > > Signed-off-by: Krzysztof Kozlowski > > Acked-by: Jonghwa Lee > > just a nit. It looks like a typo in the mail address which is also in patch 5 - > 10. Right, I copied it directly from Jonghwa's response. Thank you for noticing it. > > I applied patch 1 - 14 to my repo with a upcoming power driver (mxs_power) and > didn't see any problems with your patches. Great, thanks! Best regards, Krzysztof