linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mathias Gottschlag <mgottschlag@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
	linux-input@vger.kernel.org,
	Mathias Gottschlag <mgottschlag@gmail.com>
Subject: [PATCH 0/3] Fix a regression in the FocalTech touchpad driver
Date: Sat, 14 Feb 2015 20:01:39 +0100	[thread overview]
Message-ID: <1423940502-12353-1-git-send-email-mgottschlag@gmail.com> (raw)


Hi,

(TLDR: these patches introduce a hack in the psmouse code required for
focaltech touchpads, I am not sure whether there is any better fix)

Patch 1 cleans the code and removes two unused constants.

Patches 2 and 3 fix some problems with the FocalTech driver. Because I
totally managed to mess up Hans' fix for RedHat bug 1110011 [1], the driver did
not work for any of the affected devices.

If the touchpad was sent certain commands, it would stop responding. I did not
read the code properly and assumed that only the probing code would trigger it,
but psmouse_initialize already was enough.

The current architecture always calls psmouse_initialize after the device
specific initialization code. I have added a flag which can be set by drivers
which disables the code within psmouse_initialize, because I did not see any
cleaner way to make sure that no additional commands are sent to the touchpad.

In the same way I also implemented two stub functions focaltech_set_rate and
focaltech_set_resolution which are called instead of the generic psmouse
functions. I did not actually check whether PSMOUSE_CMD_SETRES or
PSMOUSE_CMD_SETRATE alone are enough to break the touchpad because I didn't
have enough time (or access to the hardware), so I thought I'd just play safe
and disable these functions.

The previous patch probably introduced regressions compared to 3.19, so either
these patches (or something equivalent) should go into the next release, or the
previous patch should be temporarily reverted.

Regards,
Mathias

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1110011

Mathias Gottschlag (3):
  psmouse: Remove hardcoded touchpad size from the focaltech driver.
  psmouse: Skip psmouse_initialize for FocalTech touchpads.
  psmouse: Disable resolution/rate changes for FocalTech touchpads.

 drivers/input/mouse/focaltech.c    | 24 +++++++++++++++++-------
 drivers/input/mouse/psmouse-base.c |  4 +++-
 drivers/input/mouse/psmouse.h      |  5 +++++
 3 files changed, 25 insertions(+), 8 deletions(-)

-- 
2.1.0


             reply	other threads:[~2015-02-14 19:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-14 19:01 Mathias Gottschlag [this message]
2015-02-14 19:01 ` [PATCH 1/3] psmouse: Remove hardcoded touchpad size from the focaltech driver Mathias Gottschlag
2015-02-18 19:57   ` Dmitry Torokhov
2015-02-14 19:01 ` [PATCH 2/3] psmouse: Skip psmouse_initialize for FocalTech touchpads Mathias Gottschlag
2015-02-18 19:55   ` Dmitry Torokhov
2015-02-14 19:01 ` [PATCH 3/3] psmouse: Disable resolution/rate changes " Mathias Gottschlag
2015-02-26 23:20 ` [PATCHv2 0/4] FocalTech touchpad fixes Mathias Gottschlag
2015-02-26 23:20   ` [PATCHv2 1/4] psmouse: Remove hardcoded touchpad size from the focaltech driver Mathias Gottschlag
2015-02-26 23:20   ` [PATCHv2 2/4] psmouse: Ensure that the focaltech driver reports consistent coordinates Mathias Gottschlag
2015-02-26 23:20   ` [PATCHv2 3/4] psmouse: Disable resolution/rate/scale changes for FocalTech touchpads Mathias Gottschlag
2015-03-08  4:14     ` Dmitry Torokhov
2015-02-26 23:20   ` [PATCHv2 4/4] psmouse: Disable "palm detection" in the focaltech driver Mathias Gottschlag

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1423940502-12353-1-git-send-email-mgottschlag@gmail.com \
    --to=mgottschlag@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).