From: Bastien Nocera <hadess@hadess.net>
To: Darren Hart <dvhart@infradead.org>
Cc: Henrique de Moraes Holschuh <ibm-acpi@hmh.eng.br>,
ibm-acpi-devel@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH 3/6] thinkpad_acpi: Add adaptive_kbd_mode sysfs attr
Date: Fri, 20 Feb 2015 15:36:26 +0100 [thread overview]
Message-ID: <1424442986.22910.1.camel@hadess.net> (raw)
In-Reply-To: <20150220052831.GD790@fury.dvhart.com>
On Thu, 2015-02-19 at 21:28 -0800, Darren Hart wrote:
> On Wed, Feb 18, 2015 at 09:53:44PM +0100, Bastien Nocera wrote:
>
> Commit message please.
Added.
> > Signed-off-by: Bastien Nocera <hadess@hadess.net>
> > ---
> > drivers/platform/x86/thinkpad_acpi.c | 71 +++++++++++++++++++++++++++++++-----
> > 1 file changed, 62 insertions(+), 9 deletions(-)
> >
> > diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> > index a6dd017..562d958 100644
> > --- a/drivers/platform/x86/thinkpad_acpi.c
> > +++ b/drivers/platform/x86/thinkpad_acpi.c
>
> ...
>
> > +static struct device_attribute dev_attr_adaptive_kbd_mode =
> > + __ATTR(adaptive_kbd_mode, S_IWUSR | S_IRUGO,
> > + adaptive_kbd_mode_show, adaptive_kbd_mode_store);
> > +
>
> Please use DEVICE_ATTR_RW() macros for new sysfs files.
Done.
> I'd very much like to see a cleanup of the driver to use these as well.
>
> Henrique, your thoughts / preference?
Looks easy enough. I'll post the patch with the new series.
next prev parent reply other threads:[~2015-02-20 14:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-18 20:53 [PATCH 3/6] thinkpad_acpi: Add adaptive_kbd_mode sysfs attr Bastien Nocera
2015-02-20 5:28 ` Darren Hart
2015-02-20 14:36 ` Bastien Nocera [this message]
2015-02-23 17:00 ` Henrique de Moraes Holschuh
2015-02-23 18:18 ` Bastien Nocera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424442986.22910.1.camel@hadess.net \
--to=hadess@hadess.net \
--cc=dvhart@infradead.org \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=ibm-acpi@hmh.eng.br \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).