From: Bastien Nocera <hadess@hadess.net>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Darren Hart <dvhart@infradead.org>,
ibm-acpi-devel@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
Jiri Kosina <jkosina@suse.cz>
Subject: Re: [PATCH 7/7] thinkpad_acpi: use DEVICE_ATTR_* macros
Date: Mon, 23 Feb 2015 11:27:34 +0100 [thread overview]
Message-ID: <1424687254.28361.11.camel@hadess.net> (raw)
In-Reply-To: <1424687122.3034736.231116061.6D0FF46D@webmail.messagingengine.com>
On Mon, 2015-02-23 at 07:25 -0300, Henrique de Moraes Holschuh wrote:
> On Fri, Feb 20, 2015, at 11:44, Bastien Nocera wrote:
> > Use the DEVICE_ATTR_RW macro to reduce boiler plate
>
> So far, so good, but you also used the DEVICE_ATTR_RO macro...
>
> > and move the attribute declaration to get rid of function signatures.
>
> I didn't see any "move the attribute declaration" done in this patch.
Too much cut'n'paste from another similar patch. I'll resend with a
better commit message.
> Other than that, looks good.
Great, thanks.
prev parent reply other threads:[~2015-02-23 10:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-20 14:44 [PATCH 7/7] thinkpad_acpi: use DEVICE_ATTR_* macros Bastien Nocera
2015-02-23 10:25 ` Henrique de Moraes Holschuh
2015-02-23 10:27 ` Bastien Nocera [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424687254.28361.11.camel@hadess.net \
--to=hadess@hadess.net \
--cc=dvhart@infradead.org \
--cc=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).