From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Mika Westerberg <mika.westerberg@linux.intel.com>,
Bastien Nocera <hadess@hadess.net>
Cc: Darren Hart <dvhart@infradead.org>,
ibm-acpi-devel@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
Jiri Kosina <jkosina@suse.cz>
Subject: Re: [PATCH 3/7] thinkpad_acpi: Add adaptive_kbd_mode sysfs attr
Date: Mon, 23 Feb 2015 07:28:32 -0300 [thread overview]
Message-ID: <1424687312.3036311.231116905.5FB7021B@webmail.messagingengine.com> (raw)
In-Reply-To: <20150220152032.GB1508@lahna.fi.intel.com>
On Fri, Feb 20, 2015, at 12:20, Mika Westerberg wrote:
> On Fri, Feb 20, 2015 at 03:44:22PM +0100, Bastien Nocera wrote:
> > Add a sysfs attribute to allow privileged users to change the keyboard
> > mode. This could be used by desktop environments to change the keyboard
> > mode depending on the application focused, as the Windows application
> > does.
>
> If you are adding new sysfs attributes, you should document them as well
> in Documentation/ABI/*.
The thinkpad-acpi driver has its own documentation, it is in
Documentation/laptops/thinkpad-acpi.txt.
The new adaptative keyboard stuff has to be added to it, please.
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
prev parent reply other threads:[~2015-02-23 10:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-20 14:44 [PATCH 3/7] thinkpad_acpi: Add adaptive_kbd_mode sysfs attr Bastien Nocera
2015-02-20 15:20 ` Mika Westerberg
2015-02-20 15:22 ` Bastien Nocera
2015-02-20 15:27 ` Mika Westerberg
2015-02-20 15:31 ` Bastien Nocera
2015-02-23 10:28 ` Henrique de Moraes Holschuh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424687312.3036311.231116905.5FB7021B@webmail.messagingengine.com \
--to=hmh@hmh.eng.br \
--cc=dvhart@infradead.org \
--cc=hadess@hadess.net \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).