linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Nikolai Kondrashov <spbnick@gmail.com>, Jiri Kosina <jkosina@suse.cz>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	DIGImend-devel <DIGImend-devel@lists.sourceforge.net>
Subject: [PATCH 3/4] HID: uclogic: present only the working interfaces on the Huion tablets
Date: Tue, 24 Feb 2015 19:05:29 -0500	[thread overview]
Message-ID: <1424822730-14938-4-git-send-email-benjamin.tissoires@redhat.com> (raw)
In-Reply-To: <1424822730-14938-1-git-send-email-benjamin.tissoires@redhat.com>

The Huion tablets show 3 interfaces. Only the first and the third
are currently used.
Also remove HID_QUIRK_MULTI_INPUT for the third interface to not
create more than needed input nodes.

Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
---
 drivers/hid/hid-uclogic.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/hid/hid-uclogic.c b/drivers/hid/hid-uclogic.c
index 397f1df..c03e076 100644
--- a/drivers/hid/hid-uclogic.c
+++ b/drivers/hid/hid-uclogic.c
@@ -840,6 +840,11 @@ static int uclogic_probe(struct hid_device *hdev,
 				hid_err(hdev, "tablet enabling failed\n");
 				return rc;
 			}
+		} else if (intf->cur_altsetting->desc.bInterfaceNumber == 2) {
+			hdev->quirks &= ~HID_QUIRK_MULTI_INPUT;
+		} else {
+			/* Ignore all unused interfaces */
+			return -ENODEV;
 		}
 		break;
 	}
-- 
2.1.0


  parent reply	other threads:[~2015-02-25  0:05 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-25  0:05 [PATCH 0/4] HID: huion/uclogic merge and few additions Benjamin Tissoires
2015-02-25  0:05 ` [PATCH 1/4] HID: uclogic: Set quirks from inside the driver Benjamin Tissoires
2015-02-25 21:04   ` Nikolai Kondrashov
2015-02-25 21:23     ` Benjamin Tissoires
2015-02-25  0:05 ` [PATCH 2/4] HID: uclogic: merge hid-huion driver in hid-uclogic Benjamin Tissoires
2015-02-25 21:04   ` Nikolai Kondrashov
2015-02-25 21:28     ` Benjamin Tissoires
2015-02-25 22:23       ` Nikolai Kondrashov
2015-02-25  0:05 ` Benjamin Tissoires [this message]
2015-02-25 21:04   ` [PATCH 3/4] HID: uclogic: present only the working interfaces on the Huion tablets Nikolai Kondrashov
2015-02-25 21:30     ` Benjamin Tissoires
2015-02-26 17:02       ` Benjamin Tissoires
2015-02-25  0:05 ` [PATCH 4/4] HID: uclogic: name the input nodes based on their tool Benjamin Tissoires
2015-02-25 21:04   ` Nikolai Kondrashov
2015-02-25 21:36     ` Benjamin Tissoires
2015-02-25 22:28       ` Nikolai Kondrashov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1424822730-14938-4-git-send-email-benjamin.tissoires@redhat.com \
    --to=benjamin.tissoires@redhat.com \
    --cc=DIGImend-devel@lists.sourceforge.net \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=spbnick@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).