From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Nikolai Kondrashov <spbnick@gmail.com>, Jiri Kosina <jkosina@suse.cz>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
DIGImend-devel <DIGImend-devel@lists.sourceforge.net>
Subject: [PATCH v2 5/6] HID: uclogic: discard the extra Pen input node on Huion tablets
Date: Thu, 26 Feb 2015 13:57:28 -0500 [thread overview]
Message-ID: <1424977049-18648-6-git-send-email-benjamin.tissoires@redhat.com> (raw)
In-Reply-To: <1424977049-18648-1-git-send-email-benjamin.tissoires@redhat.com>
Some Huion tablets present 2 HID Pen interfaces. Only one is used, so
we can drop the unused one.
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
---
New in v2
drivers/hid/hid-uclogic.c | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/drivers/hid/hid-uclogic.c b/drivers/hid/hid-uclogic.c
index ada8a94..f44e72b 100644
--- a/drivers/hid/hid-uclogic.c
+++ b/drivers/hid/hid-uclogic.c
@@ -713,6 +713,25 @@ static __u8 *uclogic_report_fixup(struct hid_device *hdev, __u8 *rdesc,
return rdesc;
}
+static int uclogic_input_mapping(struct hid_device *hdev, struct hid_input *hi,
+ struct hid_field *field, struct hid_usage *usage,
+ unsigned long **bit, int *max)
+{
+ struct usb_interface *intf;
+
+ if (hdev->product == USB_DEVICE_ID_HUION_TABLET) {
+ intf = to_usb_interface(hdev->dev.parent);
+
+ /* discard the unused pen interface */
+ if ((intf->cur_altsetting->desc.bInterfaceNumber != 0) &&
+ (field->application == HID_DG_PEN))
+ return -1;
+ }
+
+ /* let hid-core decide what to do */
+ return 0;
+}
+
static void uclogic_input_configured(struct hid_device *hdev,
struct hid_input *hi)
{
@@ -947,6 +966,7 @@ static struct hid_driver uclogic_driver = {
.probe = uclogic_probe,
.report_fixup = uclogic_report_fixup,
.raw_event = uclogic_raw_event,
+ .input_mapping = uclogic_input_mapping,
.input_configured = uclogic_input_configured,
};
module_hid_driver(uclogic_driver);
--
2.1.0
next prev parent reply other threads:[~2015-02-26 18:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-26 18:57 [PATCH v2 0/6] HID: huion/uclogic merge and few additions Benjamin Tissoires
2015-02-26 18:57 ` [PATCH v2 1/6] HID: uclogic: Set quirks from inside the driver Benjamin Tissoires
2015-02-26 18:57 ` [PATCH v2 2/6] HID: uclogic: merge hid-huion driver in hid-uclogic Benjamin Tissoires
2015-02-26 18:57 ` [PATCH v2 3/6] HID: uclogic: name the input nodes based on their tool Benjamin Tissoires
2015-03-01 18:04 ` Nikolai Kondrashov
2015-02-26 18:57 ` [PATCH v2 4/6] HID: uclogic: apply quirk NO_EMPTY_INPUT Benjamin Tissoires
2015-03-01 18:07 ` Nikolai Kondrashov
2015-02-26 18:57 ` Benjamin Tissoires [this message]
2015-03-01 18:13 ` [PATCH v2 5/6] HID: uclogic: discard the extra Pen input node on Huion tablets Nikolai Kondrashov
2015-02-26 18:57 ` [PATCH v2 6/6] HID: uclogic: actually invert the in-range bit for huion tablets only Benjamin Tissoires
2015-02-28 13:59 ` Nikolai Kondrashov
2015-03-02 22:25 ` Benjamin Tissoires
2015-03-03 10:54 ` Nikolai Kondrashov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424977049-18648-6-git-send-email-benjamin.tissoires@redhat.com \
--to=benjamin.tissoires@redhat.com \
--cc=DIGImend-devel@lists.sourceforge.net \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=spbnick@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).