From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Nikolai Kondrashov <spbnick@gmail.com>, Jiri Kosina <jkosina@suse.cz>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
DIGImend-devel <DIGImend-devel@lists.sourceforge.net>
Subject: [PATCH v2 6/6] HID: uclogic: actually invert the in-range bit for huion tablets only
Date: Thu, 26 Feb 2015 13:57:29 -0500 [thread overview]
Message-ID: <1424977049-18648-7-git-send-email-benjamin.tissoires@redhat.com> (raw)
In-Reply-To: <1424977049-18648-1-git-send-email-benjamin.tissoires@redhat.com>
This hack is only needed for Huion tablets. It does not seem to have
any effect on the other tablets handled by this device right now, but
it's better to check for the product id sooner than discovering that
we have messed up one tablet later.
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
---
New in v2
drivers/hid/hid-uclogic.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/hid/hid-uclogic.c b/drivers/hid/hid-uclogic.c
index f44e72b..5f5c16e 100644
--- a/drivers/hid/hid-uclogic.c
+++ b/drivers/hid/hid-uclogic.c
@@ -930,7 +930,8 @@ static int uclogic_raw_event(struct hid_device *hdev, struct hid_report *report,
struct usb_interface *intf = to_usb_interface(hdev->dev.parent);
/* If this is a pen input report */
- if (intf->cur_altsetting->desc.bInterfaceNumber == 0 &&
+ if (hdev->product == USB_DEVICE_ID_HUION_TABLET &&
+ intf->cur_altsetting->desc.bInterfaceNumber == 0 &&
report->type == HID_INPUT_REPORT &&
report->id == 0x07 && size >= 2)
/* Invert the in-range bit */
--
2.1.0
next prev parent reply other threads:[~2015-02-26 18:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-26 18:57 [PATCH v2 0/6] HID: huion/uclogic merge and few additions Benjamin Tissoires
2015-02-26 18:57 ` [PATCH v2 1/6] HID: uclogic: Set quirks from inside the driver Benjamin Tissoires
2015-02-26 18:57 ` [PATCH v2 2/6] HID: uclogic: merge hid-huion driver in hid-uclogic Benjamin Tissoires
2015-02-26 18:57 ` [PATCH v2 3/6] HID: uclogic: name the input nodes based on their tool Benjamin Tissoires
2015-03-01 18:04 ` Nikolai Kondrashov
2015-02-26 18:57 ` [PATCH v2 4/6] HID: uclogic: apply quirk NO_EMPTY_INPUT Benjamin Tissoires
2015-03-01 18:07 ` Nikolai Kondrashov
2015-02-26 18:57 ` [PATCH v2 5/6] HID: uclogic: discard the extra Pen input node on Huion tablets Benjamin Tissoires
2015-03-01 18:13 ` Nikolai Kondrashov
2015-02-26 18:57 ` Benjamin Tissoires [this message]
2015-02-28 13:59 ` [PATCH v2 6/6] HID: uclogic: actually invert the in-range bit for huion tablets only Nikolai Kondrashov
2015-03-02 22:25 ` Benjamin Tissoires
2015-03-03 10:54 ` Nikolai Kondrashov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424977049-18648-7-git-send-email-benjamin.tissoires@redhat.com \
--to=benjamin.tissoires@redhat.com \
--cc=DIGImend-devel@lists.sourceforge.net \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=spbnick@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).