linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mathias Gottschlag <mgottschlag@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	Mathias Gottschlag <mgottschlag@gmail.com>
Subject: [PATCHv2 0/4] FocalTech touchpad fixes
Date: Fri, 27 Feb 2015 00:20:04 +0100	[thread overview]
Message-ID: <1424992808-29891-1-git-send-email-mgottschlag@gmail.com> (raw)
In-Reply-To: <1423940502-12353-1-git-send-email-mgottschlag@gmail.com>

Hi,

Changes since the last version:
- I added a commit which clamps the reported coordinates to valid values, even
  if the values reported by the touchpad are wrong/misinterpreted.
- PSMOUSE_CMD_SETSCALE11 is now encapsulated in a member function of struct
  psmouse, like the other configuration commands, and focaltech.c provides
  a dummy function.
- I added a commit which disables palm detection. The driver used to check the
  reported contact size from the touchpad. However, the threshold of the value
  for "very large contact area" seems to be rather low on some devices, leading
  to frequent pointer freezes. As I don't know how to indentify these devices,
  I thought it would be better to disable the check for now. If you don't agree
  with this patch, we can surely leave it out, but I don't know how to fix the
  problem and would rather not have devices where the driver is known to be
  broken.

Especially, the last commit now removes some code which so far is the only
available documentation for the touchpad behaviour.
As soon as I find some time (haha), I'll probably write some documentation.
Would such documentation (as incomplete and probably wrong as it will be) be
suitable for Documentation/, or should I make it available through a different
channel?

Regards,
Mathias

Mathias Gottschlag (4):
  psmouse: Remove hardcoded touchpad size from the focaltech driver.
  psmouse: Ensure that the focaltech driver reports consistent
    coordinates.
  psmouse: Disable resolution/rate/scale changes for FocalTech
    touchpads.
  psmouse: Disable "palm detection" in the focaltech driver.

 drivers/input/mouse/focaltech.c    | 49 ++++++++++++++++++++++++++------------
 drivers/input/mouse/psmouse-base.c | 18 +++++++++++++-
 drivers/input/mouse/psmouse.h      |  7 ++++++
 3 files changed, 58 insertions(+), 16 deletions(-)

-- 
2.1.0


  parent reply	other threads:[~2015-02-26 23:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-14 19:01 [PATCH 0/3] Fix a regression in the FocalTech touchpad driver Mathias Gottschlag
2015-02-14 19:01 ` [PATCH 1/3] psmouse: Remove hardcoded touchpad size from the focaltech driver Mathias Gottschlag
2015-02-18 19:57   ` Dmitry Torokhov
2015-02-14 19:01 ` [PATCH 2/3] psmouse: Skip psmouse_initialize for FocalTech touchpads Mathias Gottschlag
2015-02-18 19:55   ` Dmitry Torokhov
2015-02-14 19:01 ` [PATCH 3/3] psmouse: Disable resolution/rate changes " Mathias Gottschlag
2015-02-26 23:20 ` Mathias Gottschlag [this message]
2015-02-26 23:20   ` [PATCHv2 1/4] psmouse: Remove hardcoded touchpad size from the focaltech driver Mathias Gottschlag
2015-02-26 23:20   ` [PATCHv2 2/4] psmouse: Ensure that the focaltech driver reports consistent coordinates Mathias Gottschlag
2015-02-26 23:20   ` [PATCHv2 3/4] psmouse: Disable resolution/rate/scale changes for FocalTech touchpads Mathias Gottschlag
2015-03-08  4:14     ` Dmitry Torokhov
2015-02-26 23:20   ` [PATCHv2 4/4] psmouse: Disable "palm detection" in the focaltech driver Mathias Gottschlag

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1424992808-29891-1-git-send-email-mgottschlag@gmail.com \
    --to=mgottschlag@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).