From: Markus Pargmann <mpa@pengutronix.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@pengutronix.de, Markus Pargmann <mpa@pengutronix.de>
Subject: [PATCH] input: eglx_ts, remove irq trigger flags
Date: Thu, 12 Mar 2015 15:50:16 +0100 [thread overview]
Message-ID: <1426171816-26609-1-git-send-email-mpa@pengutronix.de> (raw)
The trigger settings for a given irq are parsed from DT. Defining them
as flag for devm_request_threaded_irq() overwrites these settings. This
results in wrong trigger settings for boards which have different irq
triggers.
Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
---
drivers/input/touchscreen/egalax_ts.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/touchscreen/egalax_ts.c b/drivers/input/touchscreen/egalax_ts.c
index 4c56299284ef..b0e6448b743c 100644
--- a/drivers/input/touchscreen/egalax_ts.c
+++ b/drivers/input/touchscreen/egalax_ts.c
@@ -218,7 +218,7 @@ static int egalax_ts_probe(struct i2c_client *client,
error = devm_request_threaded_irq(&client->dev, client->irq, NULL,
egalax_ts_interrupt,
- IRQF_TRIGGER_LOW | IRQF_ONESHOT,
+ IRQF_ONESHOT,
"egalax_ts", ts);
if (error < 0) {
dev_err(&client->dev, "Failed to register interrupt\n");
--
2.1.4
next reply other threads:[~2015-03-12 14:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-12 14:50 Markus Pargmann [this message]
2015-03-12 15:18 ` [PATCH] input: eglx_ts, remove irq trigger flags Philipp Zabel
2015-03-12 15:37 ` Markus Pargmann
2015-03-12 16:28 ` Dmitry Torokhov
2015-03-13 7:14 ` Markus Pargmann
2015-03-18 16:50 ` Dmitry Torokhov
2015-03-24 10:46 ` Markus Pargmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426171816-26609-1-git-send-email-mpa@pengutronix.de \
--to=mpa@pengutronix.de \
--cc=dmitry.torokhov@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).