From: Charlie Mooney <charliemooney@chromium.org>
To: linux-input@vger.kernel.org
Cc: Benjamin Tissoires <benjamin.tissoires@gmail.com>,
Hans de Goede <hdegoede@redhat.com>,
Peter Hutterer <peter.hutterer@who-t.net>,
Andrew De Los Reyes <adlr@chromium.org>,
Henrik Rydberg <rydberg@bitmath.org>,
Jonathan Corbet <corbet@lwn.net>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Charlie Mooney <charliemooney@chromium.org>,
Masanari Iida <standby24x7@gmail.com>,
Jiri Kosina <jkosina@suse.cz>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-api@vger.kernel.org
Subject: [PATCH] Input: Add MT_TOOL_PALM
Date: Wed, 18 Mar 2015 15:26:35 -0700 [thread overview]
Message-ID: <1426717595-1610-1-git-send-email-charliemooney@chromium.org> (raw)
Currently there are only two "tools" that can be specified by a
multi-touch driver: MT_TOOL_FINGER and MT_TOOL_PEN. In working with
Elan (The touch vendor) and discussing their next-gen devices it
seems that it will be useful to have more tools so that their devices
can give the upper layers of the stack hints as to what is touching
the sensor.
In particular they have new experimental firmware that can better
differentiate between palms vs fingertips and would like to plumb a
patch so that we can use their hints in higher-level gesture soft-
ware. The firmware on the device can reasonably do a better job of
palm detection because it has access to all of the raw sensor readings
as opposed to just the width/pressure/etc that are exposed by the
driver. As such, the firmware can characterize what a palm looks like
in much finer-grained detail and this change would allow such a
device to share its findings with the kernel.
Signed-off-by: Charlie Mooney <charliemooney@chromium.org>
---
Documentation/input/multi-touch-protocol.txt | 9 ++++++---
include/uapi/linux/input.h | 3 ++-
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/Documentation/input/multi-touch-protocol.txt b/Documentation/input/multi-touch-protocol.txt
index 7b4f59c..b85d000 100644
--- a/Documentation/input/multi-touch-protocol.txt
+++ b/Documentation/input/multi-touch-protocol.txt
@@ -312,9 +312,12 @@ ABS_MT_TOOL_TYPE
The type of approaching tool. A lot of kernel drivers cannot distinguish
between different tool types, such as a finger or a pen. In such cases, the
-event should be omitted. The protocol currently supports MT_TOOL_FINGER and
-MT_TOOL_PEN [2]. For type B devices, this event is handled by input core;
-drivers should instead use input_mt_report_slot_state().
+event should be omitted. The protocol currently supports MT_TOOL_FINGER,
+MT_TOOL_PEN, and MT_TOOL_PALM [2]. For type B devices, this event is handled
+by input core; drivers should instead use input_mt_report_slot_state().
+A contact's ABS_MT_TOOL_TYPE may change over time while still touching the
+device, because the firmware may not be able to determine which tool is being
+used when it first appears.
ABS_MT_BLOB_ID
diff --git a/include/uapi/linux/input.h b/include/uapi/linux/input.h
index b0a8130..2f62ab2 100644
--- a/include/uapi/linux/input.h
+++ b/include/uapi/linux/input.h
@@ -973,7 +973,8 @@ struct input_keymap_entry {
*/
#define MT_TOOL_FINGER 0
#define MT_TOOL_PEN 1
-#define MT_TOOL_MAX 1
+#define MT_TOOL_PALM 2
+#define MT_TOOL_MAX 2
/*
* Values describing the status of a force-feedback effect
--
2.1.2
next reply other threads:[~2015-03-18 22:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 22:26 Charlie Mooney [this message]
2015-03-19 22:41 ` [PATCH] Input: Add MT_TOOL_PALM Peter Hutterer
2015-03-20 16:44 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426717595-1610-1-git-send-email-charliemooney@chromium.org \
--to=charliemooney@chromium.org \
--cc=adlr@chromium.org \
--cc=benjamin.tissoires@gmail.com \
--cc=corbet@lwn.net \
--cc=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=jkosina@suse.cz \
--cc=linux-api@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.hutterer@who-t.net \
--cc=rydberg@bitmath.org \
--cc=standby24x7@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).