[PATCH 0/3] Cleanup to get rid of a static checker warning

[PATCH 0/3] Cleanup to get rid of a static checker warning

[Ping Cheng]

Patch e2c7d8877e5c leads to the following Smatch complaint:

drivers/hid/wacom_wac.c:602 wacom_intuos_inout()
         error: we previously assumed 'wacom->shared' could be null (see line 584)

The first patch in this series fixes that warning. The next two cleans up the code
and fixes a logic order.

The patchset is based on Jiri's for-4.0/upstream-fixes branch.

Ping Cheng (3):
  HID: wacom: remove hardcoded WACOM_QUIRK_MULTI_INPUT
  HID: wacom: use wacom_wac_finger_count_touches to set touch_down
  HID: wacom: set stylus_in_proximity before checking touch_down

 drivers/hid/wacom_sys.c |  24 ++++-----
 drivers/hid/wacom_wac.c | 137 +++++++++++++++++++-----------------------------
 drivers/hid/wacom_wac.h |   9 ++--
 3 files changed, 68 insertions(+), 102 deletions(-)

-- 
1.9.1

Re: [PATCH 0/3] Cleanup to get rid of a static checker warning

[Jiri Kosina]

On Fri, 20 Mar 2015, Ping Cheng wrote:

> Patch e2c7d8877e5c leads to the following Smatch complaint:
> 
> drivers/hid/wacom_wac.c:602 wacom_intuos_inout()
>          error: we previously assumed 'wacom->shared' could be null (see line 584)
> 
> The first patch in this series fixes that warning. The next two cleans up the code
> and fixes a logic order.
> 
> The patchset is based on Jiri's for-4.0/upstream-fixes branch.
> 
> Ping Cheng (3):
>   HID: wacom: remove hardcoded WACOM_QUIRK_MULTI_INPUT
>   HID: wacom: use wacom_wac_finger_count_touches to set touch_down
>   HID: wacom: set stylus_in_proximity before checking touch_down

I've had to fix a few conflicts between for-4.1/wacom and 
for-4.1/upstream-fixes to make everything apply. Hopefully everything is 
okay, but please doublecheck.

It's now pushed out to for-4.1/wacom (and merged to for-next).

Thanks,

-- 
Jiri Kosina
SUSE Labs

Re: [PATCH 0/3] Cleanup to get rid of a static checker warning

[Ping Cheng]

On Thu, Apr 2, 2015 at 5:21 AM, Jiri Kosina <jkosina@suse.cz> wrote:
> On Fri, 20 Mar 2015, Ping Cheng wrote:
>
>> Patch e2c7d8877e5c leads to the following Smatch complaint:
>>
>> drivers/hid/wacom_wac.c:602 wacom_intuos_inout()
>>          error: we previously assumed 'wacom->shared' could be null (see line 584)
>>
>> The first patch in this series fixes that warning. The next two cleans up the code
>> and fixes a logic order.
>>
>> The patchset is based on Jiri's for-4.0/upstream-fixes branch.
>>
>> Ping Cheng (3):
>>   HID: wacom: remove hardcoded WACOM_QUIRK_MULTI_INPUT
>>   HID: wacom: use wacom_wac_finger_count_touches to set touch_down
>>   HID: wacom: set stylus_in_proximity before checking touch_down
>
> I've had to fix a few conflicts between for-4.1/wacom and
> for-4.1/upstream-fixes to make everything apply. Hopefully everything is
> okay, but please doublecheck.

I checked and tested. Everything looks good.

> It's now pushed out to for-4.1/wacom (and merged to for-next).

Thank you,

Ping