linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Gabriele Mazzotta <gabriele.mzt@gmail.com>
To: linux-input@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, dmitry.torokhov@gmail.com,
	rydberg@bitmath.org, silverhammermba@gmail.com,
	peter.hutterer@who-t.net, hdegoede@redhat.com,
	benjamin.tissoires@gmail.com, grafi@grafi.jp, oneukum@suse.de,
	Gabriele Mazzotta <gabriele.mzt@gmail.com>
Subject: [PATCH v3 1/5] input: synaptics - fix width values calculation on image sensors
Date: Sun, 22 Mar 2015 15:43:52 +0100	[thread overview]
Message-ID: <1427035436-2168-2-git-send-email-gabriele.mzt@gmail.com> (raw)
In-Reply-To: <1427035436-2168-1-git-send-email-gabriele.mzt@gmail.com>

When multiple fingers are on the touchpad, W holds the finger
count rather than the width. Retrieve the correct value that is
encoded in X, Y and Z of AGM and SGM packets.

The minimum width reported is 8 rather than 4 in this case, while the
maximum remains 15.

Signed-off-by: Gabriele Mazzotta <gabriele.mzt@gmail.com>
---
 drivers/input/mouse/synaptics.c | 21 +++++++++++++++++----
 1 file changed, 17 insertions(+), 4 deletions(-)

diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index d73a942..133e488 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -661,10 +661,12 @@ static void synaptics_parse_agm(const unsigned char buf[],
 	switch (agm_packet_type) {
 	case 1:
 		/* Gesture packet: (x, y, z) half resolution */
-		agm->w = hw->w;
-		agm->x = (((buf[4] & 0x0f) << 8) | buf[1]) << 1;
-		agm->y = (((buf[4] & 0xf0) << 4) | buf[2]) << 1;
-		agm->z = ((buf[3] & 0x30) | (buf[5] & 0x0f)) << 1;
+		agm->w = ((buf[1] & 0x01) |
+			  ((buf[2] & 0x01) << 1) |
+			  ((buf[5] & 0x01) << 2)) + 8;
+		agm->x = (((buf[4] & 0x0f) << 8) | (buf[1] & 0xfe)) << 1;
+		agm->y = (((buf[4] & 0xf0) << 4) | (buf[2] & 0xfe)) << 1;
+		agm->z = ((buf[3] & 0x30) | (buf[5] & 0x0e)) << 2;
 		break;
 
 	case 2:
@@ -960,6 +962,17 @@ static void synaptics_image_sensor_process(struct psmouse *psmouse,
 	else
 		num_fingers = 4;
 
+	/* When multiple fingers are on the TouchPad, the width is encoded in
+	 * X, Y and Z */
+	if (sgm->w == 0 || sgm->w == 1) {
+		sgm->w = (((sgm->x & BIT(1)) >> 1) |
+			  (sgm->y & BIT(1)) |
+			  ((sgm->z & BIT(0)) << 2)) + 8;
+		sgm->x &= ~BIT(1);
+		sgm->y &= ~BIT(1);
+		sgm->z &= ~BIT(0);
+	}
+
 	/* Send resulting input events to user space */
 	synaptics_report_mt_data(psmouse, sgm, num_fingers);
 }
-- 
2.1.4

  reply	other threads:[~2015-03-22 14:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-22 14:43 [PATCH v3 0/5] input: synaptics - report correct width and pressure values Gabriele Mazzotta
2015-03-22 14:43 ` Gabriele Mazzotta [this message]
2015-03-22 14:43 ` [PATCH v3 2/5] input: synaptics - change default width value of cr48 sensors Gabriele Mazzotta
2015-03-23 20:48   ` Benjamin Tissoires
2015-03-23 21:17     ` Gabriele Mazzotta
2015-03-22 14:43 ` [PATCH v3 3/5] input: synaptics - setup devices depending on their capabilities Gabriele Mazzotta
2015-03-22 14:43 ` [PATCH v3 4/5] input: synaptics - make image sensors and cr48 sensors report widths Gabriele Mazzotta
2015-06-12  0:40   ` Dmitry Torokhov
2015-06-12 18:39     ` Gabriele Mazzotta
2015-03-22 14:43 ` [PATCH v3 5/5] input: MT - add ABS_TOOL_WIDTH to the legacy pointer emulation Gabriele Mazzotta
2015-06-12  0:38   ` Dmitry Torokhov
2015-04-27 20:01 ` [PATCH v3 0/5] input: synaptics - report correct width and pressure values Gabriele Mazzotta
2015-06-09 10:26 ` Gabriele Mazzotta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1427035436-2168-2-git-send-email-gabriele.mzt@gmail.com \
    --to=gabriele.mzt@gmail.com \
    --cc=benjamin.tissoires@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=grafi@grafi.jp \
    --cc=hdegoede@redhat.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oneukum@suse.de \
    --cc=peter.hutterer@who-t.net \
    --cc=rydberg@bitmath.org \
    --cc=silverhammermba@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).