From: Gabriele Mazzotta <gabriele.mzt@gmail.com>
To: linux-input@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, dmitry.torokhov@gmail.com,
rydberg@bitmath.org, silverhammermba@gmail.com,
peter.hutterer@who-t.net, hdegoede@redhat.com,
benjamin.tissoires@gmail.com, grafi@grafi.jp, oneukum@suse.de,
Gabriele Mazzotta <gabriele.mzt@gmail.com>
Subject: [PATCH v3 4/5] input: synaptics - make image sensors and cr48 sensors report widths
Date: Sun, 22 Mar 2015 15:43:55 +0100 [thread overview]
Message-ID: <1427035436-2168-5-git-send-email-gabriele.mzt@gmail.com> (raw)
In-Reply-To: <1427035436-2168-1-git-send-email-gabriele.mzt@gmail.com>
The driver was not reporting widths for image sensors and cr48 sensors
despite it was calculating them.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=77161
Signed-off-by: Gabriele Mazzotta <gabriele.mzt@gmail.com>
---
drivers/input/mouse/synaptics.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index ff47084..4e86ba6 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -927,6 +927,7 @@ static void synaptics_report_mt_data(struct psmouse *psmouse,
input_report_abs(dev, ABS_MT_POSITION_X, pos[i].x);
input_report_abs(dev, ABS_MT_POSITION_Y, pos[i].y);
input_report_abs(dev, ABS_MT_PRESSURE, hw[i]->z);
+ input_report_abs(dev, ABS_MT_TOUCH_MAJOR, hw[i]->w);
}
input_mt_drop_unused(dev);
@@ -1192,8 +1193,9 @@ static void set_input_params(struct psmouse *psmouse,
if (SYN_CAP_IMAGE_SENSOR(priv->ext_cap_0c)) {
set_abs_position_params(dev, priv, ABS_MT_POSITION_X,
ABS_MT_POSITION_Y);
- /* Image sensors can report per-contact pressure */
+ /* Image sensors can report per-contact pressure and width */
input_set_abs_params(dev, ABS_MT_PRESSURE, 0, 255, 0, 0);
+ input_set_abs_params(dev, ABS_MT_TOUCH_MAJOR, 4, 15, 0, 0);
input_mt_init_slots(dev, 2, INPUT_MT_POINTER | INPUT_MT_TRACK);
/* Image sensors can signal 4 and 5 finger clicks */
__set_bit(BTN_TOOL_QUADTAP, dev->keybit);
@@ -1202,6 +1204,7 @@ static void set_input_params(struct psmouse *psmouse,
set_abs_position_params(dev, priv, ABS_MT_POSITION_X,
ABS_MT_POSITION_Y);
input_set_abs_params(dev, ABS_MT_PRESSURE, 0, 255, 0, 0);
+ input_set_abs_params(dev, ABS_MT_TOUCH_MAJOR, 4, 15, 0, 0);
/*
* Profile sensor in CR-48 tracks contacts reasonably well,
* other non-image sensors with AGM use semi-mt.
--
2.1.4
next prev parent reply other threads:[~2015-03-22 14:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-22 14:43 [PATCH v3 0/5] input: synaptics - report correct width and pressure values Gabriele Mazzotta
2015-03-22 14:43 ` [PATCH v3 1/5] input: synaptics - fix width values calculation on image sensors Gabriele Mazzotta
2015-03-22 14:43 ` [PATCH v3 2/5] input: synaptics - change default width value of cr48 sensors Gabriele Mazzotta
2015-03-23 20:48 ` Benjamin Tissoires
2015-03-23 21:17 ` Gabriele Mazzotta
2015-03-22 14:43 ` [PATCH v3 3/5] input: synaptics - setup devices depending on their capabilities Gabriele Mazzotta
2015-03-22 14:43 ` Gabriele Mazzotta [this message]
2015-06-12 0:40 ` [PATCH v3 4/5] input: synaptics - make image sensors and cr48 sensors report widths Dmitry Torokhov
2015-06-12 18:39 ` Gabriele Mazzotta
2015-03-22 14:43 ` [PATCH v3 5/5] input: MT - add ABS_TOOL_WIDTH to the legacy pointer emulation Gabriele Mazzotta
2015-06-12 0:38 ` Dmitry Torokhov
2015-04-27 20:01 ` [PATCH v3 0/5] input: synaptics - report correct width and pressure values Gabriele Mazzotta
2015-06-09 10:26 ` Gabriele Mazzotta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427035436-2168-5-git-send-email-gabriele.mzt@gmail.com \
--to=gabriele.mzt@gmail.com \
--cc=benjamin.tissoires@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=grafi@grafi.jp \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oneukum@suse.de \
--cc=peter.hutterer@who-t.net \
--cc=rydberg@bitmath.org \
--cc=silverhammermba@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).