From: Oliver Neukum <oneukum@suse.de>
To: Benjamin Tissoires <benjamin.tissoires@gmail.com>
Cc: Johan Hovold <johan@kernel.org>, Jiri Kosina <jkosina@suse.cz>,
linux-input <linux-input@vger.kernel.org>,
jdelvare@suse.com
Subject: Re: quirk ALWAYS_POLL needed with an unexpectedly high number of mice
Date: Fri, 27 Mar 2015 14:41:06 +0100 [thread overview]
Message-ID: <1427463666.5783.55.camel@suse.de> (raw)
In-Reply-To: <CAN+gG=FMXPmFGqdF8QR-0iSV3Y5tHr4GgfHLWPPqiZ6FStu8Pg@mail.gmail.com>
On Fri, 2015-03-27 at 09:18 -0400, Benjamin Tissoires wrote:
> On Fri, Mar 27, 2015 at 5:29 AM, Oliver Neukum <oneukum@suse.de> wrote:
> > Hi,
> >
> > I am getting reports from a customer running an unintentional
> > stress test for this quirk. I would have to add a dozen mice
> > in the medium term. Is that desirable?
> > Should we make the quirk the default? Or add a module parameter
> > to let the pessimistic users with multiple desktop rodents
> > select the quirk as default? Or just carry on?
> > Comments?
> >
>
> usbhid/hid-core.c already sets HID_QUIRK_NOGET for regular mice/keyboards [1].
> Maybe adding ALLWAYS_POLL to those would make sense and solve your problem?
It would solve my problem, but it would do so at the expense of hurting
devices that operate correctly, but only by a small amount.
> BTW I am against having this quirk as the general default because we
> rely on the usb autosuspend to shut off the touchscreens when no one
> listen to them, and the touchscreens are draining a lot of power.
I see. As long as they support remote wakeup, autosuspend will
still work. A source of remote wakeup, however, is allowed to
draw more power while suspended.
Keeping things as is is fine by me but then I will need to add a lot of
quirky devices.
Regards
Oliver
next prev parent reply other threads:[~2015-03-27 13:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-27 9:29 quirk ALWAYS_POLL needed with an unexpectedly high number of mice Oliver Neukum
2015-03-27 13:18 ` Benjamin Tissoires
2015-03-27 13:41 ` Oliver Neukum [this message]
2015-03-27 15:10 ` Jiri Kosina
2015-03-27 15:59 ` Jean Delvare
2015-03-27 16:09 ` Benjamin Tissoires
2015-03-27 16:11 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427463666.5783.55.camel@suse.de \
--to=oneukum@suse.de \
--cc=benjamin.tissoires@gmail.com \
--cc=jdelvare@suse.com \
--cc=jkosina@suse.cz \
--cc=johan@kernel.org \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).