linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "Pali Rohár" <pali.rohar@gmail.com>, linux-input@vger.kernel.org
Subject: [PATCH FIX for 4.0 0/2] alps: Report alps v2 Dualpoint Stick events via the right event node
Date: Wed,  1 Apr 2015 17:44:04 +0200	[thread overview]
Message-ID: <1427903046-26692-1-git-send-email-hdegoede@redhat.com> (raw)

Hi Dmitry & Pali,

While working on some libinput code to deal with trackpoints of different
model laptops having quite different speed / sensitivity ootb, I noticed that
with the current 4.0-rc# kernels the trackpoint events on laptops with a
PROTO_V2 alps touchpad are no longer being send by the "Dualpoint Stick"
event node, instead a new "ALPS PS/2 Mouse" node gets created and sends
the trackpoint events.

The cause of this is that the stick on these devices sends bare ps/2 packets
as data.

Although this does not really break anything (atm, it does break my libinput
work), it is still wrong, esp. also since the "Dualpoint Stick" node has
the POINTING_STICK property set, where as the "ALPS PS/2 Mouse" node which
is actually sending the stick events does not.

If still possible I would like to see this fixes added to 4.0, if not we should
queue them up for stable.

Regards,

Hans

             reply	other threads:[~2015-04-01 15:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-01 15:44 Hans de Goede [this message]
2015-04-01 15:44 ` [PATCH 1/2] alps: Report bare packets coming from alps_handle_interleaved_ps2 via dev3 Hans de Goede
2015-04-01 15:44 ` [PATCH 2/2] alps: Report alps v2 Dualpoint Stick events via the right evdev node Hans de Goede
2015-04-01 16:11 ` [PATCH FIX for 4.0 0/2] alps: Report alps v2 Dualpoint Stick events via the right event node Pali Rohár
2015-04-01 16:14   ` Hans de Goede
2015-04-01 16:39     ` Pali Rohár

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1427903046-26692-1-git-send-email-hdegoede@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=pali.rohar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).