From: Hans de Goede <hdegoede@redhat.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Hans de Bruin" <jmdebruin@xmsnet.nl>,
"Pali Rohár" <pali.rohar@gmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 4.0 REGRESSION FIX 0/1] alps: Fix left touchpad button getting stuck
Date: Wed, 8 Apr 2015 17:38:51 +0200 [thread overview]
Message-ID: <1428507532-25533-1-git-send-email-hdegoede@redhat.com> (raw)
Hi Linus, Dmitry,
Sorry for the last minute regression fix, but the existence of this regression
was not entirely clear until Hans de Bruin send a very clear reproducer this
morning.
I'm not sure if this is 4.0 material, it does fix a real regression, the fix
is pretty simple and safe (*), and when triggered the behavior (stuck mouse
button) is nasty, which all counts in favor of fixing this. OTOH this only
affects somewhat older hardware and only a certain usage pattern (using the
trackpoint with the touchpad buttons). Anyways the call if this is 4.0 material
is up to you (Linus and Dmitry), I'm just trying to make sure you're aware of
this issue and the patch.
The details of the actual bug + fix can be found in the commit msg of the
patch.
Regards,
Hans
*) The fix restores 3.19 behavior for alps v2 dualpoint touchpad/stick combos
next reply other threads:[~2015-04-08 15:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-08 15:38 Hans de Goede [this message]
2015-04-08 15:38 ` [PATCH 4.0 REGRESSION FIX] alps: Fix left touchpad button getting stuck when using it with trackpoint Hans de Goede
2015-04-08 20:26 ` Pali Rohár
2015-04-12 23:00 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1428507532-25533-1-git-send-email-hdegoede@redhat.com \
--to=hdegoede@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jmdebruin@xmsnet.nl \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).