* [PATCH] Input: sentelic - use "static inline" instead of "inline"
@ 2015-04-26 18:15 Khem Raj
2015-05-22 16:57 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Khem Raj @ 2015-04-26 18:15 UTC (permalink / raw)
To: linux-input; +Cc: Khem Raj, Dmitry Torokhov
gcc-5 defaults to gnu11 which used c99 inline semantics
in c99 'inline' is not externally visible unlike gnu89, therefore
we use 'static inline' which has same semantics between gnu89 and c99
Signed-off-by: Khem Raj <raj.khem@gmail.com>
CC: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/input/mouse/sentelic.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/input/mouse/sentelic.h b/drivers/input/mouse/sentelic.h
index aa697ec..42df9e3 100644
--- a/drivers/input/mouse/sentelic.h
+++ b/drivers/input/mouse/sentelic.h
@@ -123,11 +123,11 @@ struct fsp_data {
extern int fsp_detect(struct psmouse *psmouse, bool set_properties);
extern int fsp_init(struct psmouse *psmouse);
#else
-inline int fsp_detect(struct psmouse *psmouse, bool set_properties)
+static inline int fsp_detect(struct psmouse *psmouse, bool set_properties)
{
return -ENOSYS;
}
-inline int fsp_init(struct psmouse *psmouse)
+static inline int fsp_init(struct psmouse *psmouse)
{
return -ENOSYS;
}
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Input: sentelic - use "static inline" instead of "inline"
2015-04-26 18:15 [PATCH] Input: sentelic - use "static inline" instead of "inline" Khem Raj
@ 2015-05-22 16:57 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2015-05-22 16:57 UTC (permalink / raw)
To: Khem Raj; +Cc: linux-input
On Sun, Apr 26, 2015 at 06:15:22PM +0000, Khem Raj wrote:
> gcc-5 defaults to gnu11 which used c99 inline semantics
> in c99 'inline' is not externally visible unlike gnu89, therefore
> we use 'static inline' which has same semantics between gnu89 and c99
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> CC: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Applied, thank you.
> ---
> drivers/input/mouse/sentelic.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/mouse/sentelic.h b/drivers/input/mouse/sentelic.h
> index aa697ec..42df9e3 100644
> --- a/drivers/input/mouse/sentelic.h
> +++ b/drivers/input/mouse/sentelic.h
> @@ -123,11 +123,11 @@ struct fsp_data {
> extern int fsp_detect(struct psmouse *psmouse, bool set_properties);
> extern int fsp_init(struct psmouse *psmouse);
> #else
> -inline int fsp_detect(struct psmouse *psmouse, bool set_properties)
> +static inline int fsp_detect(struct psmouse *psmouse, bool set_properties)
> {
> return -ENOSYS;
> }
> -inline int fsp_init(struct psmouse *psmouse)
> +static inline int fsp_init(struct psmouse *psmouse)
> {
> return -ENOSYS;
> }
> --
> 2.1.4
>
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-05-22 16:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-26 18:15 [PATCH] Input: sentelic - use "static inline" instead of "inline" Khem Raj
2015-05-22 16:57 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).