From: Marek Vasut <marex@denx.de>
To: linux-input@vger.kernel.org
Cc: Marek Vasut <marex@denx.de>,
Vipul Kumar Samar <vipulkumar.samar@st.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: [PATCH] Input: smtpe-ts: Use msecs_to_jiffies() instead of HZ
Date: Wed, 6 May 2015 01:46:36 +0200 [thread overview]
Message-ID: <1430869596-7044-1-git-send-email-marex@denx.de> (raw)
Use msecs_to_jiffies(50) instead of plain (HZ / 50) as the
former is independent of kernel HZ settings and provides
stable delay.
The delay here must be stable, otherwise we might start polling
for pen-up event too early. This would in turn render the
touchscreen unusable.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Vipul Kumar Samar <vipulkumar.samar@st.com>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/input/touchscreen/stmpe-ts.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
NOTE: This applies all the way back to Linux ~2.6.36, so I should
probably also submit this for -stable if acceptable ?
diff --git a/drivers/input/touchscreen/stmpe-ts.c b/drivers/input/touchscreen/stmpe-ts.c
index 42ce31a..a8f5ea7 100644
--- a/drivers/input/touchscreen/stmpe-ts.c
+++ b/drivers/input/touchscreen/stmpe-ts.c
@@ -164,7 +164,7 @@ static irqreturn_t stmpe_ts_handler(int irq, void *data)
STMPE_TSC_CTRL_TSC_EN, STMPE_TSC_CTRL_TSC_EN);
/* start polling for touch_det to detect release */
- schedule_delayed_work(&ts->work, HZ / 50);
+ schedule_delayed_work(&ts->work, msecs_to_jiffies(50));
return IRQ_HANDLED;
}
--
2.1.4
next reply other threads:[~2015-05-05 23:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-05 23:46 Marek Vasut [this message]
2015-05-06 0:01 ` [PATCH] Input: smtpe-ts: Use msecs_to_jiffies() instead of HZ Dmitry Torokhov
2015-05-06 0:36 ` Marek Vasut
2015-05-06 23:59 ` Dmitry Torokhov
2015-05-08 1:51 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430869596-7044-1-git-send-email-marex@denx.de \
--to=marex@denx.de \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=vipulkumar.samar@st.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).