linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: linux-input@vger.kernel.org
Cc: Marek Vasut <marex@denx.de>,
	Vipul Kumar Samar <vipulkumar.samar@st.com>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: [PATCH 2/2] Input: smtpe-ts: Wait 50mS until polling for pen-up
Date: Fri,  8 May 2015 03:53:11 +0200	[thread overview]
Message-ID: <1431049991-30129-2-git-send-email-marex@denx.de> (raw)
In-Reply-To: <1431049991-30129-1-git-send-email-marex@denx.de>

Wait a little bit longer, 50mS instead of 20mS, until the driver
starts polling for pen-up. The problematic behavior before this
patch is applied is as follows. The behavior was observed on the
STMPE610QTR controller.

Upon a physical pen-down event, the touchscreen reports one set
of x-y-p coordinates and a pen-down event. After that, the pen-up
polling is triggered and since the controller is not ready yet,
the polling mistakenly detects a pen-up event while the physical
state is still such that the pen is down on the touch surface.

The pen-up handling flushes the controller FIFO, so after that,
all the samples in the controller are discarded. The controller
becomes ready shortly after this bogus pen-up handling and does
generate again a pen-down interrupt. This time, the controller
contains x-y-p samples which all read as zero. Since pressure
value is zero, this set of samples is effectively ignored by
userland.

In the end, the driver just bounces between pen-down and bogus
pen-up handling, generating no useful results. Fix this by giving
the controller a bit more time before polling it for pen-up.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Vipul Kumar Samar <vipulkumar.samar@st.com>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
 drivers/input/touchscreen/stmpe-ts.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/touchscreen/stmpe-ts.c b/drivers/input/touchscreen/stmpe-ts.c
index 9e5c880..a8f5ea7 100644
--- a/drivers/input/touchscreen/stmpe-ts.c
+++ b/drivers/input/touchscreen/stmpe-ts.c
@@ -164,7 +164,7 @@ static irqreturn_t stmpe_ts_handler(int irq, void *data)
 			STMPE_TSC_CTRL_TSC_EN, STMPE_TSC_CTRL_TSC_EN);
 
 	/* start polling for touch_det to detect release */
-	schedule_delayed_work(&ts->work, msecs_to_jiffies(20));
+	schedule_delayed_work(&ts->work, msecs_to_jiffies(50));
 
 	return IRQ_HANDLED;
 }
-- 
2.1.4


  reply	other threads:[~2015-05-08  1:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-08  1:53 [PATCH 1/2] Input: smtpe-ts: Use msecs_to_jiffies() instead of HZ Marek Vasut
2015-05-08  1:53 ` Marek Vasut [this message]
2015-05-08  2:17   ` [PATCH 2/2] Input: smtpe-ts: Wait 50mS until polling for pen-up Viresh Kumar
2015-05-08  2:15 ` [PATCH 1/2] Input: smtpe-ts: Use msecs_to_jiffies() instead of HZ Viresh Kumar
2015-05-08  5:28   ` Dmitry Torokhov
2015-05-08  9:47     ` Marek Vasut
2015-05-08 17:22       ` Dmitry Torokhov
2015-05-21 23:58         ` Marek Vasut
2015-05-22  0:01           ` Dmitry Torokhov
2015-05-22  0:05             ` Marek Vasut
2015-05-22 23:30               ` Dmitry Torokhov
2015-05-24 21:54                 ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1431049991-30129-2-git-send-email-marex@denx.de \
    --to=marex@denx.de \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=vipulkumar.samar@st.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).