linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Horan <knasher@gmail.com>
To: Jiri Kosina <jkosina@suse.cz>
Cc: linux-input@vger.kernel.org, "Michel Dänzer" <michel@daenzer.net>
Subject: Re: [PATCH] unswap the grave and 102nd keys on Apple Alu ISO keyboard
Date: Wed, 13 May 2015 12:48:17 +0100	[thread overview]
Message-ID: <1431517697.1582.1@smtp.gmail.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1505041006330.3081@pobox.suse.cz>



On Mon, May 4, 2015 at 9:07 , Jiri Kosina <jkosina@suse.cz> wrote:
> Okay, this has been there since 2007, so one would guess there must 
> be a
> reason for noone complaining about this for past 8 years. I'd rather 
> be
> careful here so that we don't introduce any regressions.
Just to follow up on this point specifically.  I actually have been 
able to find a number of people complaining about this issue[1].  
Including a patch that would have removed the quirk from this keyboard 
model, though aimed at a previous version of the code, that I guess was 
either not pushed upstream, or was rejected for some reason[2].
Looking at the code the only effect of the quirk is to swap these too 
keys, and googling for "iso_layout" and "hid_apple" shows that 
disabling this quirk is rather common advice for fixing apple 
keyboards, being mentioned on both the Ubuntu wiki[3] and the Arch 
one[4].

My issue I guess is that I have two keyboards using this module, one 
requiring the quirk, and another not.

[1]https://bugs.launchpad.net/ubuntu/+source/linux/+bug/214786
[2]https://launchpadlibrarian.net/13297091/0001-Remove-faulty-swapping-of-keys-for-Apple-USB-ISO-key.patch
[3]https://help.ubuntu.com/community/AppleKeyboard#Correcting_swapped_keys_and_wrong_keymaps_for_international_.28non-US.29_keyboards
[4]https://wiki.archlinux.org/index.php/Apple_Keyboard#.3C_and_.3E_have_changed_place_with_.5E_and_.C2.B0





      parent reply	other threads:[~2015-05-13 11:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-01  9:17 [PATCH] unswap the grave and 102nd keys on Apple Alu ISO keyboard John Horan
2015-05-04  8:07 ` Jiri Kosina
2015-05-04  8:09   ` Jiri Kosina
2015-05-04  8:11     ` Jiri Kosina
2015-05-08  2:57       ` Michel Dänzer
     [not found]         ` <1431079408.1420.0@smtp.gmail.com>
2015-05-09  8:41           ` Michel Dänzer
     [not found]             ` <1431350579.5543.0@smtp.gmail.com>
2015-05-12  0:44               ` Michel Dänzer
     [not found]                 ` <1431424549.1489.0@smtp.gmail.com>
2015-05-12 10:06                   ` Michel Dänzer
2015-05-12 11:05                     ` John Horan
2015-05-13  1:16                       ` Michel Dänzer
2015-05-13 11:48                         ` John Horan
2015-05-13 11:48   ` John Horan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1431517697.1582.1@smtp.gmail.com \
    --to=knasher@gmail.com \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=michel@daenzer.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).