From: Goffredo Baroncelli <kreijack@libero.it>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Benjamin Tissoires <benjamin.tissoires@gmail.com>,
Antonio Ospite <ao2@ao2.it>,
Nestor Lopez Casado <nlopezcasad@logitech.com>,
Dario Righelli <drighelli@gmail.com>,
linux-input@vger.kernel.org
Subject: [PATCH V6] Add support for mouse logitech m560
Date: Sat, 30 May 2015 11:00:25 +0200 [thread overview]
Message-ID: <1432976427-12013-1-git-send-email-kreijack@libero.it> (raw)
Hi All,
This is the 6th attempt for a Logitech mouse M560 hid driver.
On the basis of the feedback received, I made some changes in the code:
v6:
- hid-core.c: rename extract() to hid_field_extract() and make it linkage
external
- hid-logitech-hidpp.c: use hid_field_extract() instead of hidpp_extract()
as per Jiri request.
- update the error message in m560_raw_event() to be more specific
v5:
- simplified the checks inside m560_raw_event()
- rearranged the return codes in m560_raw_event(): 0 in case the frame is not
corrected, 1 if the data are correct. This is the behavior observed in
other drivers, even if the returned values may vary.
The patch is against v4.1-rc5.
Special thanks to Antonio and Benjamin for their support and testing.
BR
G.Baroncelli
--
gpg <at> keyserver.linux.it: Goffredo Baroncelli <kreijackATinwind.it>
Key fingerprint BBF5 1610 0B64 DAC6 5F7D 17B2 0EDA 9B37 8B82 E0B5
next reply other threads:[~2015-05-30 9:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-30 9:00 Goffredo Baroncelli [this message]
2015-05-30 9:00 ` [PATCH 1/2] Export hid_field_extract() Goffredo Baroncelli
2015-05-30 9:00 ` [PATCH 2/2] Add driver for mouse logitech M560 Goffredo Baroncelli
2015-06-01 12:39 ` Jiri Kosina
2015-06-02 12:07 ` Goffredo Baroncelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432976427-12013-1-git-send-email-kreijack@libero.it \
--to=kreijack@libero.it \
--cc=ao2@ao2.it \
--cc=benjamin.tissoires@gmail.com \
--cc=drighelli@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=nlopezcasad@logitech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).