* [PATCH 1/1 linux-next] HID: use swap() in cp_report_fixup()
@ 2015-06-10 16:32 Fabian Frederick
2015-06-18 9:01 ` Jiri Kosina
0 siblings, 1 reply; 2+ messages in thread
From: Fabian Frederick @ 2015-06-10 16:32 UTC (permalink / raw)
To: linux-kernel; +Cc: Julia Lawall, Fabian Frederick, Jiri Kosina, linux-input
Use kernel.h macro definition.
Thanks to Julia Lawall for Coccinelle scripting support.
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
drivers/hid/hid-cypress.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/hid/hid-cypress.c b/drivers/hid/hid-cypress.c
index c4ef3bc..1b764d1 100644
--- a/drivers/hid/hid-cypress.c
+++ b/drivers/hid/hid-cypress.c
@@ -41,13 +41,9 @@ static __u8 *cp_report_fixup(struct hid_device *hdev, __u8 *rdesc,
for (i = 0; i < *rsize - 4; i++)
if (rdesc[i] == 0x29 && rdesc[i + 2] == 0x19) {
- __u8 tmp;
-
rdesc[i] = 0x19;
rdesc[i + 2] = 0x29;
- tmp = rdesc[i + 3];
- rdesc[i + 3] = rdesc[i + 1];
- rdesc[i + 1] = tmp;
+ swap(rdesc[i + 3], rdesc[i + 1]);
}
return rdesc;
}
--
2.4.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1 linux-next] HID: use swap() in cp_report_fixup()
2015-06-10 16:32 [PATCH 1/1 linux-next] HID: use swap() in cp_report_fixup() Fabian Frederick
@ 2015-06-18 9:01 ` Jiri Kosina
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Kosina @ 2015-06-18 9:01 UTC (permalink / raw)
To: Fabian Frederick; +Cc: linux-kernel, Julia Lawall, linux-input
On Wed, 10 Jun 2015, Fabian Frederick wrote:
> Use kernel.h macro definition.
>
> Thanks to Julia Lawall for Coccinelle scripting support.
>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
Applied to for-4.2/upstream. Thanks.
> ---
> drivers/hid/hid-cypress.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/hid/hid-cypress.c b/drivers/hid/hid-cypress.c
> index c4ef3bc..1b764d1 100644
> --- a/drivers/hid/hid-cypress.c
> +++ b/drivers/hid/hid-cypress.c
> @@ -41,13 +41,9 @@ static __u8 *cp_report_fixup(struct hid_device *hdev, __u8 *rdesc,
>
> for (i = 0; i < *rsize - 4; i++)
> if (rdesc[i] == 0x29 && rdesc[i + 2] == 0x19) {
> - __u8 tmp;
> -
> rdesc[i] = 0x19;
> rdesc[i + 2] = 0x29;
> - tmp = rdesc[i + 3];
> - rdesc[i + 3] = rdesc[i + 1];
> - rdesc[i + 1] = tmp;
> + swap(rdesc[i + 3], rdesc[i + 1]);
> }
> return rdesc;
> }
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-06-18 9:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-10 16:32 [PATCH 1/1 linux-next] HID: use swap() in cp_report_fixup() Fabian Frederick
2015-06-18 9:01 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).