From: Oliver Neukum <oneukum@suse.de>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Tom Gundersen <teg@jklm.no>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH][RFC] usbhid: enable autosuspend for internal devices
Date: Mon, 29 Jun 2015 13:37:19 +0200 [thread overview]
Message-ID: <1435577839.1805.10.camel@suse.de> (raw)
In-Reply-To: <alpine.LNX.2.00.1506291315360.10183@pobox.suse.cz>
On Mon, 2015-06-29 at 13:16 +0200, Jiri Kosina wrote:
> On Mon, 29 Jun 2015, Oliver Neukum wrote:
>
> > > Last time we were testing this, autosuspend for USB HID devices was quite
> > > a disaster.
> > >
> > > Do you have any idea whether udev developers tested the "autosuspend on by
> > > default for USB HID devices" on reasonable set of devices?
> > >
> > > The culrpits that I remember from top of my head (it's been long time
> > > ago):
> > >
> > > - the LEDs for suspended device go off. This is very confusing at least on
> > > keyboards, and brings really bad user experience
> >
> > That is a bug. hidinput_count_leds() is supposed to prevent that.
>
> This is a HW property and nothing kernel can do about. I am not saying it
> doesn't bring the LEDs up to a proper state again once auto-resumed. But I
> hate the LEDs going off a few seconds after I stop typing (i.e. once the
> keyboard gets auto-suspended).
That is the point. Unless you give the option to override, they
shouldn't autosuspend.
Regards
Oliver
next prev parent reply other threads:[~2015-06-29 11:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-26 19:24 [PATCH][RFC] usbhid: enable autosuspend for internal devices Tom Gundersen
2015-06-26 19:32 ` Greg Kroah-Hartman
2015-06-26 20:08 ` Alan Stern
2015-06-26 20:28 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1506261549310.1566-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2015-06-26 22:15 ` Greg Kroah-Hartman
[not found] ` <20150626221517.GB2761-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2015-06-27 1:20 ` Alan Stern
2015-06-27 1:29 ` Greg Kroah-Hartman
2015-06-27 6:29 ` Jiri Kosina
[not found] ` <alpine.LNX.2.00.1506270825010.10183-ztGlSCb7Y1iN3ZZ/Hiejyg@public.gmane.org>
2015-06-27 15:31 ` Greg Kroah-Hartman
2015-06-30 15:21 ` Alan Stern
2015-06-29 9:48 ` Oliver Neukum
2015-06-29 11:16 ` Jiri Kosina
2015-06-29 11:37 ` Oliver Neukum [this message]
[not found] ` <1435577839.1805.10.camel-l3A5Bk7waGM@public.gmane.org>
2015-06-29 12:00 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435577839.1805.10.camel@suse.de \
--to=oneukum@suse.de \
--cc=gregkh@linuxfoundation.org \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=teg@jklm.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).