* [PATCH] Input: drv260x/drv2665/drv2667 - Constify reg_default tables
@ 2015-07-07 1:01 Axel Lin
2015-07-08 15:26 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2015-07-07 1:01 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: Dan Murphy, linux-input
These reg_default tables are not modified after initialized, so make them
const.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/input/misc/drv260x.c | 2 +-
drivers/input/misc/drv2665.c | 2 +-
drivers/input/misc/drv2667.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/input/misc/drv260x.c b/drivers/input/misc/drv260x.c
index e5d60ec..0e3af55 100644
--- a/drivers/input/misc/drv260x.c
+++ b/drivers/input/misc/drv260x.c
@@ -204,7 +204,7 @@ struct drv260x_data {
int overdrive_voltage;
};
-static struct reg_default drv260x_reg_defs[] = {
+static const struct reg_default drv260x_reg_defs[] = {
{ DRV260X_STATUS, 0xe0 },
{ DRV260X_MODE, 0x40 },
{ DRV260X_RT_PB_IN, 0x00 },
diff --git a/drivers/input/misc/drv2665.c b/drivers/input/misc/drv2665.c
index 0afaa33..e9501fd 100644
--- a/drivers/input/misc/drv2665.c
+++ b/drivers/input/misc/drv2665.c
@@ -74,7 +74,7 @@ static const u8 drv2665_sine_wave_form[] = {
0x9b, 0x9f, 0xa5, 0xad, 0xb8, 0xc4, 0xd2, 0xe0, 0xf0, 0x00,
};
-static struct reg_default drv2665_reg_defs[] = {
+static const struct reg_default drv2665_reg_defs[] = {
{ DRV2665_STATUS, 0x02 },
{ DRV2665_CTRL_1, 0x28 },
{ DRV2665_CTRL_2, 0x40 },
diff --git a/drivers/input/misc/drv2667.c b/drivers/input/misc/drv2667.c
index fc0fddf..a231342 100644
--- a/drivers/input/misc/drv2667.c
+++ b/drivers/input/misc/drv2667.c
@@ -116,7 +116,7 @@ struct drv2667_data {
u32 frequency;
};
-static struct reg_default drv2667_reg_defs[] = {
+static const struct reg_default drv2667_reg_defs[] = {
{ DRV2667_STATUS, 0x02 },
{ DRV2667_CTRL_1, 0x28 },
{ DRV2667_CTRL_2, 0x40 },
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Input: drv260x/drv2665/drv2667 - Constify reg_default tables
2015-07-07 1:01 [PATCH] Input: drv260x/drv2665/drv2667 - Constify reg_default tables Axel Lin
@ 2015-07-08 15:26 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2015-07-08 15:26 UTC (permalink / raw)
To: Axel Lin; +Cc: Dan Murphy, linux-input
On Tue, Jul 07, 2015 at 09:01:39AM +0800, Axel Lin wrote:
> These reg_default tables are not modified after initialized, so make them
> const.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Applied, thank you.
> ---
> drivers/input/misc/drv260x.c | 2 +-
> drivers/input/misc/drv2665.c | 2 +-
> drivers/input/misc/drv2667.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/input/misc/drv260x.c b/drivers/input/misc/drv260x.c
> index e5d60ec..0e3af55 100644
> --- a/drivers/input/misc/drv260x.c
> +++ b/drivers/input/misc/drv260x.c
> @@ -204,7 +204,7 @@ struct drv260x_data {
> int overdrive_voltage;
> };
>
> -static struct reg_default drv260x_reg_defs[] = {
> +static const struct reg_default drv260x_reg_defs[] = {
> { DRV260X_STATUS, 0xe0 },
> { DRV260X_MODE, 0x40 },
> { DRV260X_RT_PB_IN, 0x00 },
> diff --git a/drivers/input/misc/drv2665.c b/drivers/input/misc/drv2665.c
> index 0afaa33..e9501fd 100644
> --- a/drivers/input/misc/drv2665.c
> +++ b/drivers/input/misc/drv2665.c
> @@ -74,7 +74,7 @@ static const u8 drv2665_sine_wave_form[] = {
> 0x9b, 0x9f, 0xa5, 0xad, 0xb8, 0xc4, 0xd2, 0xe0, 0xf0, 0x00,
> };
>
> -static struct reg_default drv2665_reg_defs[] = {
> +static const struct reg_default drv2665_reg_defs[] = {
> { DRV2665_STATUS, 0x02 },
> { DRV2665_CTRL_1, 0x28 },
> { DRV2665_CTRL_2, 0x40 },
> diff --git a/drivers/input/misc/drv2667.c b/drivers/input/misc/drv2667.c
> index fc0fddf..a231342 100644
> --- a/drivers/input/misc/drv2667.c
> +++ b/drivers/input/misc/drv2667.c
> @@ -116,7 +116,7 @@ struct drv2667_data {
> u32 frequency;
> };
>
> -static struct reg_default drv2667_reg_defs[] = {
> +static const struct reg_default drv2667_reg_defs[] = {
> { DRV2667_STATUS, 0x02 },
> { DRV2667_CTRL_1, 0x28 },
> { DRV2667_CTRL_2, 0x40 },
> --
> 2.1.0
>
>
>
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-08 15:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-07 1:01 [PATCH] Input: drv260x/drv2665/drv2667 - Constify reg_default tables Axel Lin
2015-07-08 15:26 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).