From: Paul Bolle <pebolle@tiscali.nl>
To: Robert Dolca <robert.dolca@intel.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Henrik Rydberg <rydberg@bitmath.org>
Subject: Re: [PATCH] Add generic driver for Silead tochscreens
Date: Sat, 11 Jul 2015 15:05:23 +0200 [thread overview]
Message-ID: <1436619923.2679.5.camel@tiscali.nl> (raw)
In-Reply-To: <1436541064-13381-1-git-send-email-robert.dolca@intel.com>
On vr, 2015-07-10 at 18:11 +0300, Robert Dolca wrote:
> +static struct i2c_driver silead_ts_driver = {
> + [...]
> + .driver = {
> + [...]
> +#ifdef CONFIG_ACPI
> + .acpi_match_table = ACPI_PTR(silead_ts_acpi_match),
> +#endif
A nit: for the !CONFIG_ACPI case include/linux/acpi.h contains
#define ACPI_PTR(_ptr) (NULL)
So I think the above CONFIG_ACPI guard is superfluous and can be dropped.
> +[...]
> + },
> +};
Thanks,
Paul Bolle
next prev parent reply other threads:[~2015-07-11 13:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-10 15:11 [PATCH] Add generic driver for Silead tochscreens Robert Dolca
2015-07-11 13:05 ` Paul Bolle [this message]
2015-07-20 6:51 ` Dmitry Torokhov
2015-07-20 12:05 ` Robert Dolca
2015-07-27 21:30 ` Dmitry Torokhov
2015-07-28 7:23 ` Robert Dolca
-- strict thread matches above, loose matches on Subject: below --
2015-07-11 21:23 Gregor Riepl
2015-07-12 6:31 ` Dmitry Torokhov
2015-07-13 9:59 ` Robert Dolca
2015-07-13 12:21 ` Gregor Riepl
2015-07-13 14:24 ` Gregor Riepl
2015-07-13 14:52 ` Robert Dolca
2015-07-13 15:18 ` Gregor Riepl
2015-07-16 13:59 ` Gregor Riepl
2015-07-20 21:19 ` Robert Dolca
2015-07-20 21:13 ` Robert Dolca
2015-07-21 13:21 ` Gregor Riepl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436619923.2679.5.camel@tiscali.nl \
--to=pebolle@tiscali.nl \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robert.dolca@intel.com \
--cc=rydberg@bitmath.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).