From: Andrew Shadura <andrew.shadura@collabora.co.uk>
To: Linux Input Mailing List <linux-input@vger.kernel.org>
Subject: [PATCH v2] HID: update PenMount USB report descriptor so that only one button is reported
Date: Thu, 23 Jul 2015 18:20:15 +0200 [thread overview]
Message-ID: <1437668415-14569-1-git-send-email-andrew.shadura@collabora.co.uk> (raw)
In-Reply-To: <1437394064-13881-1-git-send-email-andrew.shadura@collabora.co.uk>
PenMount USB resistive touchscreen reports it has three buttons, while in reality
it doesn't have any and doesn't support active styli, and only generates touch
events.
Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk>
---
drivers/hid/hid-penmount.c | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/drivers/hid/hid-penmount.c b/drivers/hid/hid-penmount.c
index c11dce8..98ea1c12 100644
--- a/drivers/hid/hid-penmount.c
+++ b/drivers/hid/hid-penmount.c
@@ -30,6 +30,23 @@ static int penmount_input_mapping(struct hid_device *hdev,
return 0;
}
+static __u8 *penmount_report_fixup(struct hid_device *hdev, __u8 *rdesc,
+ unsigned int *rsize)
+{
+ if (*rsize == 76 &&
+ rdesc[2] == 0x09 && rdesc[3] == 0x02 /* mouse */ &&
+ rdesc[22] == 0x05 && rdesc[23] == 0x09 /* button */ &&
+ rdesc[26] == 0x29 && rdesc[27] == 0x03 /* maximum */ &&
+ rdesc[32] == 0x95 && rdesc[33] == 0x02 /* report count */) {
+ hid_info(hdev,
+ "fixing up PenMount USB touchscreen report descriptor\n");
+
+ rdesc[27] = 0x01; /* just one button */
+ rdesc[33] = 0x01; /* just one report */
+ }
+ return rdesc;
+}
+
static const struct hid_device_id penmount_devices[] = {
{ HID_USB_DEVICE(USB_VENDOR_ID_PENMOUNT, USB_DEVICE_ID_PENMOUNT_6000) },
{ }
@@ -39,6 +56,7 @@ MODULE_DEVICE_TABLE(hid, penmount_devices);
static struct hid_driver penmount_driver = {
.name = "hid-penmount",
.id_table = penmount_devices,
+ .report_fixup = penmount_report_fixup,
.input_mapping = penmount_input_mapping,
};
--
2.1.4
next prev parent reply other threads:[~2015-07-23 16:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 12:07 [PATCH] HID: update PenMount USB report descriptor so that only one button is reported Andrew Shadura
2015-07-23 16:20 ` Andrew Shadura [this message]
2015-10-13 14:08 ` [PATCH v2] " Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437668415-14569-1-git-send-email-andrew.shadura@collabora.co.uk \
--to=andrew.shadura@collabora.co.uk \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).