* [PATCH v1] HID: sensor-hub: Fixup for Lenovo ThinkPad Helix 2 sensor hub report
@ 2015-09-03 15:56 Fernando D S Lima
2015-09-03 20:00 ` Srinivas Pandruvada
0 siblings, 1 reply; 3+ messages in thread
From: Fernando D S Lima @ 2015-09-03 15:56 UTC (permalink / raw)
To: Srinivas Pandruvada
Cc: Fernando D S Lima, Jiri Kosina, Jonathan Cameron, linux-input,
linux-iio, linux-kernel
There is an error in the report descriptor of the Thinkpad Helix 2 where
logical minimum value (557376) is greater than logical maximum (491200)
for all of the magnetic flux axis data fields. This error results in a
report descriptor parsing failure that causes the sensors attached to the
hub not to be detected.
dmesg excerpt:
[ 19.866905] drivers/hid/hid-core.c: logical range invalid 0x88140 0x77ec0
[ 19.866914] hid-sensor-hub 0018:2047:0855.0007: item 0 1 0 8 parsing failed
[ 19.866926] hid-sensor-hub 0018:2047:0855.0007: parse failed
[ 19.866933] hid-sensor-hub: probe of 0018:2047:0855.0007 failed with error -22
Add a report fixup to change magnetic flux logical minimums to -557376
for the parsing to succeed and the sensors to get detected.
After applying the fix the sensors get detected, with corresponding drivers
(hid-accel-3d,hid-gyro-3d,etc) loaded, and its possible to read their values.
Signed-off-by: Fernando D S Lima <fernandodsl@gmail.com>
---
drivers/hid/hid-sensor-hub.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c
index 090a1ba..6c94257 100644
--- a/drivers/hid/hid-sensor-hub.c
+++ b/drivers/hid/hid-sensor-hub.c
@@ -593,6 +593,20 @@ static __u8 *sensor_hub_report_fixup(struct hid_device *hdev, __u8 *rdesc,
}
}
+ /* Checks if the report descriptor of Thinkpad Helix 2 has a logical
+ * minimum for magnetic flux axis greater than the maximum */
+ if (hdev->product == USB_DEVICE_ID_TEXAS_INSTRUMENTS_LENOVO_YOGA &&
+ *rsize == 2558 && rdesc[913] == 0x17 && rdesc[914] == 0x40 &&
+ rdesc[915] == 0x81 && rdesc[916] == 0x08 &&
+ rdesc[917] == 0x00 && rdesc[918] == 0x27 &&
+ rdesc[921] == 0x07 && rdesc[922] == 0x00) {
+ /* Sets negative logical minimum for mag x, y and z */
+ rdesc[914] = rdesc[935] = rdesc[956] = 0xc0;
+ rdesc[915] = rdesc[936] = rdesc[957] = 0x7e;
+ rdesc[916] = rdesc[937] = rdesc[958] = 0xf7;
+ rdesc[917] = rdesc[938] = rdesc[959] = 0xff;
+ }
+
return rdesc;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v1] HID: sensor-hub: Fixup for Lenovo ThinkPad Helix 2 sensor hub report
2015-09-03 15:56 [PATCH v1] HID: sensor-hub: Fixup for Lenovo ThinkPad Helix 2 sensor hub report Fernando D S Lima
@ 2015-09-03 20:00 ` Srinivas Pandruvada
2015-09-04 12:48 ` Jiri Kosina
0 siblings, 1 reply; 3+ messages in thread
From: Srinivas Pandruvada @ 2015-09-03 20:00 UTC (permalink / raw)
To: Fernando D S Lima
Cc: Jiri Kosina, Jonathan Cameron, linux-input, linux-iio,
linux-kernel
On Thu, 2015-09-03 at 12:56 -0300, Fernando D S Lima wrote:
> There is an error in the report descriptor of the Thinkpad Helix 2
> where
> logical minimum value (557376) is greater than logical maximum
> (491200)
> for all of the magnetic flux axis data fields. This error results in
> a
> report descriptor parsing failure that causes the sensors attached to
> the
> hub not to be detected.
>
> dmesg excerpt:
> [ 19.866905] drivers/hid/hid-core.c: logical range invalid 0x88140
> 0x77ec0
> [ 19.866914] hid-sensor-hub 0018:2047:0855.0007: item 0 1 0 8
> parsing failed
> [ 19.866926] hid-sensor-hub 0018:2047:0855.0007: parse failed
> [ 19.866933] hid-sensor-hub: probe of 0018:2047:0855.0007 failed
> with error -22
>
> Add a report fixup to change magnetic flux logical minimums to
> -557376
> for the parsing to succeed and the sensors to get detected.
> After applying the fix the sensors get detected, with corresponding
> drivers
> (hid-accel-3d,hid-gyro-3d,etc) loaded, and its possible to read their
> values.
>
> Signed-off-by: Fernando D S Lima <fernandodsl@gmail.com>
Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
> drivers/hid/hid-sensor-hub.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor
> -hub.c
> index 090a1ba..6c94257 100644
> --- a/drivers/hid/hid-sensor-hub.c
> +++ b/drivers/hid/hid-sensor-hub.c
> @@ -593,6 +593,20 @@ static __u8 *sensor_hub_report_fixup(struct
> hid_device *hdev, __u8 *rdesc,
> }
> }
>
> + /* Checks if the report descriptor of Thinkpad Helix 2 has a
> logical
> + * minimum for magnetic flux axis greater than the maximum
> */
> + if (hdev->product ==
> USB_DEVICE_ID_TEXAS_INSTRUMENTS_LENOVO_YOGA &&
> + *rsize == 2558 && rdesc[913] == 0x17 && rdesc[914]
> == 0x40 &&
> + rdesc[915] == 0x81 && rdesc[916] == 0x08 &&
> + rdesc[917] == 0x00 && rdesc[918] == 0x27 &&
> + rdesc[921] == 0x07 && rdesc[922] == 0x00) {
> + /* Sets negative logical minimum for mag x, y and z
> */
> + rdesc[914] = rdesc[935] = rdesc[956] = 0xc0;
> + rdesc[915] = rdesc[936] = rdesc[957] = 0x7e;
> + rdesc[916] = rdesc[937] = rdesc[958] = 0xf7;
> + rdesc[917] = rdesc[938] = rdesc[959] = 0xff;
> + }
> +
> return rdesc;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v1] HID: sensor-hub: Fixup for Lenovo ThinkPad Helix 2 sensor hub report
2015-09-03 20:00 ` Srinivas Pandruvada
@ 2015-09-04 12:48 ` Jiri Kosina
0 siblings, 0 replies; 3+ messages in thread
From: Jiri Kosina @ 2015-09-04 12:48 UTC (permalink / raw)
To: Srinivas Pandruvada
Cc: Fernando D S Lima, Jonathan Cameron, linux-input, linux-iio,
linux-kernel
On Thu, 3 Sep 2015, Srinivas Pandruvada wrote:
> On Thu, 2015-09-03 at 12:56 -0300, Fernando D S Lima wrote:
> > There is an error in the report descriptor of the Thinkpad Helix 2
> > where
> > logical minimum value (557376) is greater than logical maximum
> > (491200)
> > for all of the magnetic flux axis data fields. This error results in
> > a
> > report descriptor parsing failure that causes the sensors attached to
> > the
> > hub not to be detected.
> >
> > dmesg excerpt:
> > [ 19.866905] drivers/hid/hid-core.c: logical range invalid 0x88140
> > 0x77ec0
> > [ 19.866914] hid-sensor-hub 0018:2047:0855.0007: item 0 1 0 8
> > parsing failed
> > [ 19.866926] hid-sensor-hub 0018:2047:0855.0007: parse failed
> > [ 19.866933] hid-sensor-hub: probe of 0018:2047:0855.0007 failed
> > with error -22
> >
> > Add a report fixup to change magnetic flux logical minimums to
> > -557376
> > for the parsing to succeed and the sensors to get detected.
> > After applying the fix the sensors get detected, with corresponding
> > drivers
> > (hid-accel-3d,hid-gyro-3d,etc) loaded, and its possible to read their
> > values.
> >
> > Signed-off-by: Fernando D S Lima <fernandodsl@gmail.com>
> Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Applied to for-4.3/upstream-fixes. Thanks,
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-09-04 12:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-03 15:56 [PATCH v1] HID: sensor-hub: Fixup for Lenovo ThinkPad Helix 2 sensor hub report Fernando D S Lima
2015-09-03 20:00 ` Srinivas Pandruvada
2015-09-04 12:48 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).