From: WEN Pingbo <pingbo.wen@linaro.org>
To: dmitry.torokhov@gmail.com
Cc: broonie@kernel.org, linux-input@vger.kernel.org,
WEN Pingbo <pingbo.wen@linaro.org>
Subject: [PATCH 1/2] Input: at32psif: handle clk_enable return value
Date: Fri, 11 Sep 2015 11:02:55 +0800 [thread overview]
Message-ID: <1441940576-4972-1-git-send-email-pingbo.wen@linaro.org> (raw)
We should print the err if clk_enable failed.
Signed-off-by: WEN Pingbo <pingbo.wen@linaro.org>
---
drivers/input/serio/at32psif.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/input/serio/at32psif.c b/drivers/input/serio/at32psif.c
index 2e4ff5b..aebb996 100644
--- a/drivers/input/serio/at32psif.c
+++ b/drivers/input/serio/at32psif.c
@@ -185,6 +185,7 @@ static void psif_set_prescaler(struct psif *psif)
{
unsigned long prscv;
unsigned long rate = clk_get_rate(psif->pclk);
+ int retval;
/* PRSCV = Pulse length (100 us) * PSIF module frequency. */
prscv = 100 * (rate / 1000000UL);
@@ -195,7 +196,10 @@ static void psif_set_prescaler(struct psif *psif)
"prescaler set to max\n");
}
- clk_enable(psif->pclk);
+ retval = clk_enable(psif->pclk);
+ if (retval < 0)
+ dev_err(&psif->pdev->dev,
+ "could not enable pclk, ret %d\n", retval);
psif_writel(psif, PSR, prscv);
clk_disable(psif->pclk);
}
--
1.9.1
next reply other threads:[~2015-09-11 3:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-11 3:02 WEN Pingbo [this message]
2015-09-11 3:02 ` [PATCH 2/2] Input: lpc32xx: handle clk_enable return value WEN Pingbo
2015-09-11 3:10 ` [PATCH 1/2] Input: at32psif: " Fabio Estevam
2015-09-11 3:21 ` Pingbo Wen
2015-09-11 3:34 ` [PATCH V2 " WEN Pingbo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441940576-4972-1-git-send-email-pingbo.wen@linaro.org \
--to=pingbo.wen@linaro.org \
--cc=broonie@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).