* [PATCH] Input: elan_i2c - fix X205TA iap version
@ 2015-09-12 7:24 Michele Curti
2015-09-12 16:14 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Michele Curti @ 2015-09-12 7:24 UTC (permalink / raw)
To: dusonlin; +Cc: dmitry.torokhov, linux-input, Michele Curti
After commit commit 58f1eae48e53 ("Input: elan_i2c - use iap_version to
get firmware information") the touchpad on the Asus X205TA does not
work anymore, iap version is 0, so modify the switch-case index.
The 0x08 case was added for the X205TA in commit 534fcb3bdaab ("Input:
elan_i2c - enable ELAN0100 acpi panels")
Signed-off-by: Michele Curti <michele.curti@gmail.com>
---
drivers/input/mouse/elan_i2c_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/mouse/elan_i2c_core.c b/drivers/input/mouse/elan_i2c_core.c
index fa94530..c40a02d 100644
--- a/drivers/input/mouse/elan_i2c_core.c
+++ b/drivers/input/mouse/elan_i2c_core.c
@@ -98,7 +98,7 @@ static int elan_get_fwinfo(u8 iap_version, u16 *validpage_count,
u16 *signature_address)
{
switch (iap_version) {
- case 0x08:
+ case 0x00:
*validpage_count = 512;
break;
case 0x09:
--
2.5.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Input: elan_i2c - fix X205TA iap version
2015-09-12 7:24 [PATCH] Input: elan_i2c - fix X205TA iap version Michele Curti
@ 2015-09-12 16:14 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2015-09-12 16:14 UTC (permalink / raw)
To: Michele Curti; +Cc: Duson Lin, linux-input@vger.kernel.org
HI Michele,
On Sat, Sep 12, 2015 at 12:24 AM, Michele Curti <michele.curti@gmail.com> wrote:
> After commit commit 58f1eae48e53 ("Input: elan_i2c - use iap_version to
> get firmware information") the touchpad on the Asus X205TA does not
> work anymore, iap version is 0, so modify the switch-case index.
>
> The 0x08 case was added for the X205TA in commit 534fcb3bdaab ("Input:
> elan_i2c - enable ELAN0100 acpi panels")
>
I'll sit on this patch a bit - I have a feeling will have to revert
58f1eae48e53.
Thanks.
> Signed-off-by: Michele Curti <michele.curti@gmail.com>
> ---
> drivers/input/mouse/elan_i2c_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/mouse/elan_i2c_core.c b/drivers/input/mouse/elan_i2c_core.c
> index fa94530..c40a02d 100644
> --- a/drivers/input/mouse/elan_i2c_core.c
> +++ b/drivers/input/mouse/elan_i2c_core.c
> @@ -98,7 +98,7 @@ static int elan_get_fwinfo(u8 iap_version, u16 *validpage_count,
> u16 *signature_address)
> {
> switch (iap_version) {
> - case 0x08:
> + case 0x00:
> *validpage_count = 512;
> break;
> case 0x09:
> --
> 2.5.1
>
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-09-12 16:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-12 7:24 [PATCH] Input: elan_i2c - fix X205TA iap version Michele Curti
2015-09-12 16:14 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).