From: Irina Tirdea <irina.tirdea@intel.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Bastien Nocera <hadess@hadess.net>,
Aleksei Mamlin <mamlinav@gmail.com>,
linux-input@vger.kernel.org
Cc: Mark Rutland <mark.rutland@arm.com>,
Octavian Purdila <octavian.purdila@intel.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Irina Tirdea <irina.tirdea@intel.com>
Subject: [PATCH v6 6/9] Input: goodix - use goodix_i2c_write_u8 instead of i2c_master_send
Date: Tue, 15 Sep 2015 17:31:20 +0300 [thread overview]
Message-ID: <1442327483-19407-7-git-send-email-irina.tirdea@intel.com> (raw)
In-Reply-To: <1442327483-19407-1-git-send-email-irina.tirdea@intel.com>
Use goodix_i2c_write_u8 instead of i2c_master_send to simplify code.
Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
---
drivers/input/touchscreen/goodix.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c
index 1993b6c..ee87d38 100644
--- a/drivers/input/touchscreen/goodix.c
+++ b/drivers/input/touchscreen/goodix.c
@@ -295,16 +295,11 @@ static void goodix_process_events(struct goodix_ts_data *ts)
*/
static irqreturn_t goodix_ts_irq_handler(int irq, void *dev_id)
{
- static const u8 end_cmd[] = {
- GOODIX_READ_COOR_ADDR >> 8,
- GOODIX_READ_COOR_ADDR & 0xff,
- 0
- };
struct goodix_ts_data *ts = dev_id;
goodix_process_events(ts);
- if (i2c_master_send(ts->client, end_cmd, sizeof(end_cmd)) < 0)
+ if (goodix_i2c_write_u8(ts->client, GOODIX_READ_COOR_ADDR, 0) < 0)
dev_err(&ts->client->dev, "I2C write end_cmd error\n");
return IRQ_HANDLED;
--
1.9.1
next prev parent reply other threads:[~2015-09-15 14:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 14:31 [PATCH v6 0/9] Goodix touchscreen enhancements Irina Tirdea
2015-09-15 14:31 ` [PATCH v6 1/9] Input: goodix - sort includes alphabetically Irina Tirdea
2015-09-15 14:31 ` [PATCH v6 2/9] Input: goodix - use actual config length for each device type Irina Tirdea
2015-09-15 14:31 ` [PATCH v6 3/9] Input: goodix - reset device at init Irina Tirdea
2015-09-21 21:54 ` Aleksei Mamlin
2015-09-15 14:31 ` [PATCH v6 4/9] Input: goodix - write configuration data to device Irina Tirdea
2015-09-25 14:40 ` Bastien Nocera
[not found] ` <1443192040.17020.26.camel-0MeiytkfxGOsTnJN9+BGXg@public.gmane.org>
2015-09-25 21:18 ` Tirdea, Irina
2015-09-15 14:31 ` [PATCH v6 5/9] Input: goodix - add power management support Irina Tirdea
2015-09-15 14:31 ` Irina Tirdea [this message]
2015-09-15 14:31 ` [PATCH v6 7/9] Input: goodix - add support for ESD Irina Tirdea
[not found] ` <1442327483-19407-1-git-send-email-irina.tirdea-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-09-15 14:31 ` [PATCH v6 8/9] Input: goodix - add sysfs interface to dump config Irina Tirdea
2015-09-15 14:31 ` [PATCH v6 9/9] Input: goodix - add runtime power management support Irina Tirdea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442327483-19407-7-git-send-email-irina.tirdea@intel.com \
--to=irina.tirdea@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=hadess@hadess.net \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mamlinav@gmail.com \
--cc=mark.rutland@arm.com \
--cc=octavian.purdila@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).