From: Stephen Chandler Paul <cpaul@redhat.com>
To: aksgarg1989@gmail.com, Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
Subject: Re: [PATCH] Input: Use for_each_set_bit where appropriate
Date: Thu, 17 Sep 2015 16:02:47 -0400 [thread overview]
Message-ID: <1442520167.3355.13.camel@redhat.com> (raw)
In-Reply-To: <1436378929-65748-1-git-send-email-aksgarg1989@gmail.com>
Hi! The currently upstream version of this patch actually breaks
uinput, and causes the kernel to panic when attempting to run it under
qemu using spice. Here's a backtrace from kdb:
Stack traceback for pid 656
0xffff8800babed480 656 1 1 2 R 0xffff8800babefa80 *spice-vdagentd
ffff88013747bd58 0000000000000018 ffff88013747bd80 ffff8800b7977000
0000000000000003 0000000000000001 0000000000000001 ffff8800b7977240
ffff88013747bdc0 ffffffff8163f449 0000000000000286 0000000000000018
Call Trace:
[<ffffffff8163f449>] ? input_event+0x59/0x80
[<ffffffffa0509234>] ? uinput_write+0x154/0x460 [uinput]
[<ffffffffa00e704d>] ? port_fops_read+0xfd/0x1f0 [virtio_console]
[<ffffffff81261627>] ? __vfs_write+0x37/0x100
[<ffffffff81261ff9>] ? vfs_write+0xa9/0x1a0
[<ffffffff81283386>] ? __fget_light+0x66/0x90
[<ffffffff81262cf8>] ? SyS_write+0x58/0xd0
[<ffffffff81833c72>] ? entry_SYSCALL_64_fastpath+0x12/0x76
And the relevant messages from dmesg:
<1>[ 15.064330] BUG: unable to handle kernel NULL pointer dereference at 0000000000000024
<1>[ 15.064336] IP: [<ffffffff8163f142>] input_handle_event+0x232/0x4e0
<4>[ 15.064343] PGD 0
<4>[ 15.064345] Oops: 0000 [#1] SMP
The steps for reproducing this are pretty simple: setup a Fedora 22 VM,
build the latest kernel and install it with make install, and try to
boot the machine and use it over spice with qemu. After moving the
cursor it'll run into a NULL dereference and panic.
I've tested reverting this commit, and that fixes the NULL dereference
completely. I'm willing to git send-email you the revert if wish.
Cheers,
Lyude
next prev parent reply other threads:[~2015-09-17 20:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 18:08 [PATCH] Input: Use for_each_set_bit where appropriate Anshul Garg
2015-09-17 20:02 ` Stephen Chandler Paul [this message]
2015-09-19 18:26 ` Dmitry Torokhov
2015-09-21 14:30 ` Stephen Chandler Paul
2015-09-21 22:58 ` Dmitry Torokhov
-- strict thread matches above, loose matches on Subject: below --
2015-07-09 13:41 Anshul Garg
2015-07-09 17:26 ` Dmitry Torokhov
2015-07-09 17:35 ` Anshul Garg
2015-07-09 18:14 ` Dmitry Torokhov
2015-07-09 18:17 ` Anshul Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442520167.3355.13.camel@redhat.com \
--to=cpaul@redhat.com \
--cc=1436449261-66742-1-git-send-email-aksgarg1989@gmail.com \
--cc=aksgarg1989@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).