* [PATCH] Input: goldfish - Allow compile the driver with COMPILE_TEST
@ 2015-10-02 14:47 Javier Martinez Canillas
2015-10-02 17:53 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Javier Martinez Canillas @ 2015-10-02 14:47 UTC (permalink / raw)
To: linux-kernel
Cc: Luis de Bethencourt, Javier Martinez Canillas, Hans de Goede,
Linus Walleij, Scott Branden, Robin Gong, Dmitry Torokhov,
Lee Jones, Geert Uytterhoeven, Matt Ranostay, linux-input,
Frank Li
The driver depends on GOLDFISH but there isn't a build dependency
so it's a good idea to allow the driver to be built even if that
option is disabled, if the COMPILE_TEST option is enabled.
That way, the driver can be built with a config generated by make
allyesconfig and can be checked if a patch would break the build.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/input/keyboard/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig
index 2e80107ff630..ddd8148d51d7 100644
--- a/drivers/input/keyboard/Kconfig
+++ b/drivers/input/keyboard/Kconfig
@@ -516,7 +516,7 @@ config KEYBOARD_SAMSUNG
module will be called samsung-keypad.
config KEYBOARD_GOLDFISH_EVENTS
- depends on GOLDFISH
+ depends on GOLDFISH || COMPILE_TEST
tristate "Generic Input Event device for Goldfish"
help
Say Y here to get an input event device for the Goldfish virtual
--
2.4.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Input: goldfish - Allow compile the driver with COMPILE_TEST
2015-10-02 14:47 [PATCH] Input: goldfish - Allow compile the driver with COMPILE_TEST Javier Martinez Canillas
@ 2015-10-02 17:53 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2015-10-02 17:53 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: linux-kernel, Luis de Bethencourt, Hans de Goede, Linus Walleij,
Scott Branden, Robin Gong, Lee Jones, Geert Uytterhoeven,
Matt Ranostay, linux-input, Frank Li
On Fri, Oct 02, 2015 at 04:47:58PM +0200, Javier Martinez Canillas wrote:
> The driver depends on GOLDFISH but there isn't a build dependency
> so it's a good idea to allow the driver to be built even if that
> option is disabled, if the COMPILE_TEST option is enabled.
>
> That way, the driver can be built with a config generated by make
> allyesconfig and can be checked if a patch would break the build.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
Applied, thank you.
> ---
>
> drivers/input/keyboard/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig
> index 2e80107ff630..ddd8148d51d7 100644
> --- a/drivers/input/keyboard/Kconfig
> +++ b/drivers/input/keyboard/Kconfig
> @@ -516,7 +516,7 @@ config KEYBOARD_SAMSUNG
> module will be called samsung-keypad.
>
> config KEYBOARD_GOLDFISH_EVENTS
> - depends on GOLDFISH
> + depends on GOLDFISH || COMPILE_TEST
> tristate "Generic Input Event device for Goldfish"
> help
> Say Y here to get an input event device for the Goldfish virtual
> --
> 2.4.3
>
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-02 17:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-02 14:47 [PATCH] Input: goldfish - Allow compile the driver with COMPILE_TEST Javier Martinez Canillas
2015-10-02 17:53 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).