linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: fcooper@ti.com
To: dmitry.torokhov@gmail.com, linux-input@vger.kernel.org,
	linux-kernel@vger.kernel.org, fcooper@ti.com,
	maxime.ripard@free-electrons.com, LW@KARO-electronics.de,
	jg1.han@samsung.com, asaf.vertz@tandemg.com
Subject: [RFC 1/4] Input: edt-ft5x06 - Use max support points to determine how much to read
Date: Wed,  7 Oct 2015 07:21:38 -0500	[thread overview]
Message-ID: <1444220501-23623-2-git-send-email-fcooper@ti.com> (raw)
In-Reply-To: <1444220501-23623-1-git-send-email-fcooper@ti.com>

From: Franklin S Cooper Jr <fcooper@ti.com>

Calculate the amount of data that needs to be read for the specified max
number of support points. If the maximum number of support points changes
then the amount that is read from the touch screen controller should
reflect this.

Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
---
 drivers/input/touchscreen/edt-ft5x06.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c
index 7239c31..1e0ed6e 100644
--- a/drivers/input/touchscreen/edt-ft5x06.c
+++ b/drivers/input/touchscreen/edt-ft5x06.c
@@ -178,14 +178,16 @@ static irqreturn_t edt_ft5x06_ts_isr(int irq, void *dev_id)
 		cmd = 0xf9; /* tell the controller to send touch data */
 		offset = 5; /* where the actual touch data starts */
 		tplen = 4;  /* data comes in so called frames */
-		datalen = 26; /* how much bytes to listen for */
+
+		/* how many bytes to listen for */
+		datalen = tplen * MAX_SUPPORT_POINTS + offset + 1;
 		break;
 
 	case M09:
 		cmd = 0x02;
 		offset = 1;
 		tplen = 6;
-		datalen = 29;
+		datalen = tplen * MAX_SUPPORT_POINTS - cmd + 1;
 		break;
 
 	default:
-- 
2.6.1

  reply	other threads:[~2015-10-07 12:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-07 12:21 [RFC 0/4] Input: edt-ft5506 - Adding support for FT5506 fcooper
2015-10-07 12:21 ` fcooper [this message]
2015-10-14 23:39   ` [RFC 1/4] Input: edt-ft5x06 - Use max support points to determine how much to read Dmitry Torokhov
2015-10-15  1:58     ` Franklin S Cooper Jr.
2015-10-16  0:16       ` Dmitry Torokhov
2015-10-16  0:43         ` Franklin S Cooper Jr.
2015-10-16  0:44           ` Franklin S Cooper Jr.
2015-10-16  0:47           ` Dmitry Torokhov
2015-10-16  0:54             ` Franklin S Cooper Jr.
2015-10-16  0:57               ` Dmitry Torokhov
2015-10-07 12:21 ` [RFC 2/4] Input: edt-ft5x06 - Add support for different max support points fcooper
2015-10-07 12:21 ` [RFC 3/4] Input: edt-ft5x06 - Add support for FT5506 fcooper
2015-10-07 12:21 ` [RFC 4/4] Input: edt-ft5x06 - Work around FT5506 firmware bug fcooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1444220501-23623-2-git-send-email-fcooper@ti.com \
    --to=fcooper@ti.com \
    --cc=LW@KARO-electronics.de \
    --cc=asaf.vertz@tandemg.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jg1.han@samsung.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime.ripard@free-electrons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).